Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: examples/developer_guide/3_simple_cpp_stage fails to build in release container #2149

Open
2 tasks done
dagardner-nv opened this issue Jan 29, 2025 · 1 comment · May be fixed by #2155
Open
2 tasks done

[BUG]: examples/developer_guide/3_simple_cpp_stage fails to build in release container #2149

dagardner-nv opened this issue Jan 29, 2025 · 1 comment · May be fixed by #2155
Assignees
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

25.02

Which installation method(s) does this occur on?

Docker

Describe the bug.

This fails to build as a stand-alone package (not with -DMORPHEUS_BUILD_EXAMPLES=ON).

Minimum reproducible example

./docker/run_container_release.sh
conda env update --solver=libmamba -n morpheus --file /workspace/conda/environments/dev_cuda-125_arch-$(arch).yaml
cd examples/developer_guide/3_simple_cpp_stage
./compile.sh

Relevant log output

Click here to see error details
/opt/conda/envs/morpheus/include/glog/logging.h:711:25: error: 'MakeCheckOpValueString' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
  711 |   MakeCheckOpValueString(comb.ForVar2(), v2);
      |   ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
ninja: build stopped: subcommand failed.

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Jan 29, 2025
@dagardner-nv dagardner-nv self-assigned this Jan 29, 2025
@dagardner-nv dagardner-nv added this to the 25.02 - Release milestone Jan 29, 2025
@dagardner-nv
Copy link
Contributor Author

Bare-metal repro:

cmake -B build -DCMAKE_BUILD_TYPE=Debug -GNinja -DCMAKE_MESSAGE_CONTEXT_SHOW=ON -DMORPHEUS_USE_CLANG_TIDY=OFF  -DMORPHEUS_PYTHON_INPLACE_BUILD=OFF -DMORPHEUS_USE_CONDA=ON  -DMORPHEUS_BUILD_EXAMPLES=OFF -DMORPHEUS_PYTHON_PERFORM_INSTALL=ON MORPHEUS_PYTHON_BUILD_STUBS=OFF .

cmake --build build --target install

cd examples/developer_guide/3_simple_cpp_stage
./compile.sh

@morpheus-bot-test morpheus-bot-test bot moved this from Todo to Review - Ready for Review in Morpheus Boards Jan 29, 2025
dagardner-nv added a commit that referenced this issue Jan 30, 2025
rapids-bot bot pushed a commit that referenced this issue Jan 30, 2025
* Explicitly call `find_package(glog REQUIRED)` and link to `glog::glog` in C++ examples
* This is a work-around for issue #2149

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Will Killian (https://github.com/willkill07)

URL: #2156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Review - Ready for Review
1 participant