docs: Callout limited default font-weights #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijkvanzanten
commented
Nov 24, 2024
| @@ -63,6 +63,10 @@ div { | |||
|
|
|||
| That's it! Nuxt Fonts will detect this and you should immediately see the web font loaded in your browser. [Read more about how it works](/advanced#how-it-works). | |||
|
|
|||
| ::callout{icon="i-heroicons-exclamation-triangle" color="amber"} | |||
There was a problem hiding this comment.
This icon/color combo is pulled from the Nuxt UI docs; not sure if the icon set used here is available in the docs for @nuxt/fonts
| @@ -45,6 +45,12 @@ export default defineNuxtConfig({ | |||
| }) | |||
| ``` | |||
|
|
|||
| #### `weights` | |||
There was a problem hiding this comment.
This was missing prior. Technically this is a somewhat unrelated change to the current PR, but figured I'd save your inbox from yet another issue/PR combo for this inoffensive tweak 😁
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
=======================================
Coverage 83.85% 83.85%
=======================================
Files 13 13
Lines 1016 1016
Branches 266 266
=======================================
Hits 852 852
Misses 158 158
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
danielroe
approved these changes
Nov 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Ref #209 (comment)
❓ Type of change
📚 Description
For a new user, it's not immediately obvious that only the 400 font weight is loaded for fonts. This PR aims to improve that by calling it out during the installation and troubleshooting steps.