Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support import.meta.* for vite #1297

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Aug 25, 2024

πŸ”— Linked issue

#1295

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR supports import.meta.* in vite mode.
webpack 4 does not support import.meta, so we need to create a plugin.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx marked this pull request as ready for review August 25, 2024 09:40
@wattanx wattanx requested a review from danielroe August 25, 2024 09:40
@danielroe danielroe merged commit 1166be4 into main Aug 25, 2024
61 checks passed
@danielroe danielroe deleted the feat/support-import-meta branch August 25, 2024 09:45
@github-actions github-actions bot mentioned this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants