Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test release #5698

Open
wants to merge 16 commits into
base: wip-NXDRIVE-2929-upgrade-python-from-3.9.5-to-3.13.1
Choose a base branch
from

Conversation

gitofanindya
Copy link
Collaborator

@gitofanindya gitofanindya commented Mar 28, 2025

Summary by Sourcery

Upgrade Python from version 3.9.5 to 3.13.1 across the project, including dependencies, CI workflows, and documentation

New Features:

  • Upgrade to Python 3.13.1 with associated compatibility updates

Enhancements:

  • Update project-wide Python version references
  • Modify datetime handling to use timezone-aware datetime
  • Update dependency versions to be compatible with Python 3.13

CI:

  • Update GitHub Actions workflows to use Python 3.13
  • Modify deployment and testing scripts to reference Python 3.13.1

Documentation:

  • Update documentation to reflect new Python version support

Copy link
Contributor

sourcery-ai bot commented Mar 28, 2025

Reviewer's Guide by Sourcery

This pull request upgrades the Python version to 3.13.1, updates dependencies, adapts the code to use timezone aware datetimes, fixes and improves the Windows installer signing process, and includes miscellaneous test fixes and improvements.

Updated class diagram for AutoRetryCursor

classDiagram
  class AutoRetryCursor {
    +execute(sql: str, parameters: Iterable[Any] = ()) : Cursor
    +adapt_datetime_iso(val: Any) : Any
    +reg_adptr(param: datetime) : Any
  }
Loading

File-Level Changes

Change Details Files
Upgrade Python version from 3.9.5 to 3.13.1.
  • Update Python version in multiple workflow files.
  • Update Python version in deployment documentation.
  • Update Python version check in __main__.py.
  • Update Python version in agent deployment scripts.
tools/posix/deploy_ci_agent.sh
tools/windows/deploy_ci_agent.ps1
nxdrive/__main__.py
docs/deployment.md
.github/workflows/release.yml
.github/workflows/functional_tests.yml
.github/workflows/functional_tests_2023.yml
.github/workflows/functional_tests_2025.yml
.github/workflows/unit_tests.yml
.github/workflows/dead_code.yml
.github/workflows/integration_tests.yml
.github/workflows/lint.yml
.github/workflows/spell.yml
.github/workflows/style.yml
.github/workflows/translations.yml
.github/workflows/types.yml
docs/gnu_linux.md
docs/support.md
Update dependency versions in requirements.txt.
  • Update boto3 from 1.35.21 to 1.37.11.
  • Update botocore from 1.35.21 to 1.37.11.
  • Update cffi from 1.16.0 to 1.17.1.
  • Update packaging from 24.0 to 24.2.
  • Update pywin32 from 301 to 308.
  • Update s3transfer from 0.10.0 to 0.11.4.
  • Update six from 1.16.0 to 1.17.0.
  • Update zipp from 3.20.0 to 3.21.0.
tools/deps/requirements.txt
Adapt the code to use timezone aware datetimes.
  • Use datetime.now(tz=timezone.utc) instead of datetime.utcnow() to store timezone aware datetimes in the database.
  • Adapt the adapt_datetime_iso method to handle timezone aware datetimes.
nxdrive/dao/base.py
nxdrive/dao/engine.py
nxdrive/engine/watcher/remote_watcher.py
nxdrive/engine/engine.py
nxdrive/utils.py
nxdrive/client/local/base.py
Fixes and improvements to the Windows installer signing process.
  • Add new secrets for 2025 testing.
  • Add a new signing ID.
  • Add validation against 2025 Nuxeo Drive beta.
  • Add username and password for testing.
.github/workflows/release.yml
Miscellaneous test fixes and improvements.
  • Add a test case for scanning remote files.
  • Add a test case for getting file info.
  • Fix a test case for fatal errors.
  • Fix a test case for dumping the database.
  • Fix a test case for checking the last sync date.
  • Remove a mocked path class.
tests/functional/test_remote_watcher.py
tests/unit/test_local_client.py
tests/integration/windows/test_cli.py
tests/unit/test_utils.py
tests/functional/test_engine.py
tests/unit/conftest.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gitofanindya gitofanindya changed the base branch from master to wip-NXDRIVE-2929-upgrade-python-from-3.9.5-to-3.13.1 March 28, 2025 06:34
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.08%. Comparing base (4201799) to head (badc276).

Additional details and impacted files
@@                                   Coverage Diff                                    @@
##           wip-NXDRIVE-2929-upgrade-python-from-3.9.5-to-3.13.1    #5698      +/-   ##
========================================================================================
- Coverage                                                 52.09%   52.08%   -0.01%     
========================================================================================
  Files                                                        96       96              
  Lines                                                     16131    16131              
========================================================================================
- Hits                                                       8403     8402       -1     
- Misses                                                     7728     7729       +1     
Flag Coverage Δ
functional 42.88% <ø> (-0.01%) ⬇️
integration 2.00% <ø> (ø)
unit 40.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant