Improved schema validation for eth_getBalance #598
+127
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow any type of context variable for the eth address parameter * The non-empty array is not an acceptable schema for parameters. What we want is a one-element tuple
✅ Deploy Preview for taco-demo canceled.
|
✅ Deploy Preview for taco-nft-demo canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic-v0.6.x #598 +/- ##
==============================================
Coverage ? 89.20%
==============================================
Files ? 73
Lines ? 6500
Branches ? 345
==============================================
Hits ? 5798
Misses ? 664
Partials ? 38 ☔ View full report in Codecov by Sentry. |
derekpierre
reviewed
Oct 18, 2024
|
|
||
| const BLOCK_HASH_REGEXP = new RegExp('^0x[a-fA-F0-9]{64}$'); | ||
| const BlockNumber = z.number().int().nonnegative(); | ||
| const BlockHash = z.string().regex(BLOCK_HASH_REGEXP); |
There was a problem hiding this comment.
Suggested change
| const BlockHash = z.string().regex(BLOCK_HASH_REGEXP); | |
| const BlockHash = z.string().regex(BLOCK_HASH_REGEXP, 'Invalid block hash'); |
| @@ -109,7 +143,7 @@ describe('validation', () => { | |||
| expect(result.data).toBeUndefined(); | |||
| expect(result.error?.format()).toMatchObject({ | |||
| parameters: { | |||
| _errors: ['Array must contain at least 1 element(s)'], | |||
| _errors: ['Array must contain at least 2 element(s)', 'Array must contain at least 1 element(s)'], | |||
There was a problem hiding this comment.
I did some digging around to see if there is a way to work around this - it's a little conflicting to have both i.e. at least 2 element(s) and at least 1 element(s) - but I couldn't find anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
Why it's needed:
Notes for reviewers: