fix: timeslot filter item doesn't update. Fixes #427

nthumodifications · Aug 19, 2024 · c263ec0 · c263ec0
1 parent 3a9e680
commit c263ec0
Showing 1 changed file with 7 additions and 23 deletions.
diff --git a/src/app/[lang]/(mods-pages)/courses/TimeslotFilterItem.tsx b/src/app/[lang]/(mods-pages)/courses/TimeslotFilterItem.tsx
@@ -61,7 +61,6 @@ const TimeslotFilterItem = ({
 
   const [searchValue, setSearchValue] = useState("");
   const [searching, setSearching] = useState(false);
-  const [selected, setSelected] = useState<string[]>([]);
 
   const items = mode == "exact" ? timesItems : separateItems;
   const refine = mode == "exact" ? timesRefine : separateRefine;
@@ -77,15 +76,13 @@ const TimeslotFilterItem = ({
   };
 
   useEffect(() => {
-    if (timeslotValue.length > 0) {
-      clearRefine();
-      if (mode == "includes") {
-        for (let i = 0; i < timeslotValue.length; i++) {
-          refine(timeslotValue[i]);
-        }
-      } else {
-        refine([...timeslotValue].sort(customSort).join(""));
+    clearRefine();
+    if (mode == "includes") {
+      for (let i = 0; i < timeslotValue.length; i++) {
+        refine(timeslotValue[i]);
       }
+    } else {
+      refine([...timeslotValue].sort(customSort).join(""));
     }
   }, [mode, timeslotValue, clearRefine, refine]);
 
@@ -96,7 +93,6 @@ const TimeslotFilterItem = ({
     }
     if (name == "") {
       const refinedItems = items.filter((item) => item.isRefined);
-      setSelected(refinedItems.map((item) => item.value));
     }
   };
 
@@ -116,21 +112,9 @@ const TimeslotFilterItem = ({
 
   const clear = () => {
     setTimeslotValue([]);
-    setSelected([]);
     clearRefine();
   };
 
-  useEffect(() => {
-    clearRefine();
-    if (mode == "includes") {
-      for (let i = 0; i < timeslotValue.length; i++) {
-        refine(timeslotValue[i]);
-      }
-    } else {
-      refine([...timeslotValue].sort(customSort).join(""));
-    }
-  }, [timeslotValue, mode, refine, clearRefine]);
-
   const handleFillTimes = useCallback(() => {
     const timeslots = getSemesterCourses(semester)
       .map((course) =>
@@ -164,7 +148,7 @@ const TimeslotFilterItem = ({
             <span className="truncate">
               {searching ? (
                 "Selecting..."
-              ) : selected.length == 0 ? (
+              ) : timeslotValue.length == 0 ? (
                 "All"
               ) : (
                 <div className="flex flex-col gap-1">