Skip to content

Commit

Permalink
fix: semester used by wrong one
Browse files Browse the repository at this point in the history
  • Loading branch information
ImJustChew committed Apr 15, 2024
1 parent da60c28 commit 1011483
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/app/[lang]/(mods-pages)/student/grades/GradesViewer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,13 @@ const GradesViewer = ({ grades }: { grades: GradeObject }) => {
// get unique semesters
const semesters = Array.from(new Set(grades.ranking.data.map(grade => grade.year + grade.semester))).toReversed();
// grades might have semesters that are not in ranking
const gradesSemesters = grades.grades.map(grade => grade.year + grade.semester);

const gradesSemesters = Array.from(new Set(grades.grades.map(grade => grade.year + grade.semester))).toReversed();
const displayGrades = grades.grades.filter(grade => {
if (selectedSemester == "All") return true;
return grade.year + grade.semester == selectedSemester;
});

const displayedSemesters = semesters.filter(semester => {
const displayedSemesters = gradesSemesters.filter(semester => {
if (selectedSemester == "All") return true;
return semester == selectedSemester;
});
Expand Down

0 comments on commit 1011483

Please sign in to comment.