Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of working from pull request #130

Open
kaihendry opened this issue Nov 7, 2023 · 1 comment
Open

Example of working from pull request #130

kaihendry opened this issue Nov 7, 2023 · 1 comment

Comments

@kaihendry
Copy link

I've noticed this action doesn't work off the "main" branch very well.

We have a Pull Request review flow and I tried:

with:
          main-branch-name: ${{ github.ref_name }}

Though it errored with:

No explicit --head argument provided, but found environment variable NX_HEAD so using its value as the affected head

I re-read https://github.com/nrwl/nx-set-shas#problem and am I right to assume it's a solved problem with a PR workflow? If it is, why mention it in the README other to confuse dopes like me. =)

@mandarini
Copy link
Member

Hi there @kaihendry ! Thanks for filing this issue! Do you think this is just a documentation issue, and can be fixed by rewording the readme? What do you think would sound less confusing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants