fix: disconnect called before connection has completed #107 #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix
fixes #107
The cause was the assignment of
_socketProcess
happening async, meaning that ifdisconnect
ordestroy
was called before that promise had resolved, then it would look likeconnect
had never been called, and the cleanup would be skippedThere are two parts here.
_isDisconnecting
is used bydisconnect
to skip the call to the threadsconnect
method ifdisconnect
is called while the thread is being created. Once the thread is created,disconnect
previously operated as expected_creatingSocket
is used bydestroy
, so that it can wait for the thread creation to complete before attempting to destroy the thread. in the future, maybe this creation can be abortable, but that will require changes in threadedclassOnly given a very light synthetic test so far.