[nrf noup] scripts: west: build: Use sysbuild by default if in NCS dir #1713
Conversation
Uses sysbuild by default when building an application which resides in an allowed NCS-based directory when the sysbuild config key is not set Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
| @@ -9,6 +9,11 @@ | |||
| import sys | |||
| import yaml | |||
|
|
|||
| from pathlib import Path | |||
There was a problem hiding this comment.
pathlib is already imported above:
There was a problem hiding this comment.
It does not work without this line
There was a problem hiding this comment.
it does, you just have to use pathlib.Path(...) instead of Path(...).
| from pathlib import Path | ||
| from zephyr_ext_common import ZEPHYR_BASE | ||
| sys.path.append(os.fspath(Path(__file__).parent.parent)) | ||
| import zephyr_module |
There was a problem hiding this comment.
Why importing zephyr_module and not the native Manifest provided by west ?
like this:
from west.manifest import Manifest
and then simply fetch the projects using a manifest.get_projects([]) call ?
iirc you can even pass list of project to return, like:
manifest.get_projects([allow_list])
There was a problem hiding this comment.
Because this does not work with optional modules
There was a problem hiding this comment.
what does not work ?
Modules passed with -DEXTRA_ZEPHYR_MODULES ?
Or inactive Zephyr projects ?
The manifest.get_projects([]) should return projects if they are active.
|
Has been moved to #1706 |
Uses sysbuild by default when building an application which resides in an allowed NCS-based directory when the sysbuild config key is not set