Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast_pair: Fix bt_fast_pair partition for TF-M + change TF-M profile in fast_pair samples #20489

Conversation

mkapala-nordic
Copy link
Contributor

@mkapala-nordic mkapala-nordic commented Feb 19, 2025

Jira: NCSDK-31901
Jira: NCSDK-31777

Will add changelog later

@mkapala-nordic mkapala-nordic requested review from nordicjm, tejlmand and a team as code owners February 19, 2025 13:02
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 19, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 19, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 8b6e6004647023eebeb428c6d2dcd7f8617ec242

more details

sdk-nrf:

PR head: 8b6e6004647023eebeb428c6d2dcd7f8617ec242
merge base: 42863f5c6879014035f8f9eeb12fcee06b41b3f4
target head (main): 96683e2782923209e3f4bb9e6e0b48db770afee7
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (9)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── bluetooth
│  │  ├── fast_pair
│  │  │  ├── input_device
│  │  │  │  ├── boards
│  │  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.conf
│  │  │  ├── locator_tag
│  │  │  │  ├── configuration
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp_ns.conf
│  │  │  │  │  │  ├── nrf5340dk_nrf5340_cpuapp_ns_release.conf
│  │  │  │  │  │  ├── thingy53_nrf5340_cpuapp_ns.conf
│  │  │  │  │  │  │ thingy53_nrf5340_cpuapp_ns_release.conf
│  │  │  │  │  ├── pm_static_nrf5340dk_nrf5340_cpuapp_ns.yml
│  │  │  │  │  │ pm_static_thingy53_nrf5340_cpuapp_ns.yml
subsys
│  ├── partition_manager
│  │  │ pm.yml.bt_fast_pair

Outputs:

Toolchain

Version: 4cff34261a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4cff34261a_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 6
  • ✅ Integration tests
    • ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-proprietary_esb - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run
    • ⚠️ test-fw-nrfconnect-fw-update

Note: This message is automatically posted and updated by the CI

@mkapala-nordic mkapala-nordic force-pushed the upmerge/20241220/post-cleanup-fp-ns-targets-fix branch from ae7689e to bcba759 Compare February 19, 2025 13:07
@kapi-no
Copy link
Contributor

kapi-no commented Feb 19, 2025

Can we bring into the review someone from the Aegir team?

@kapi-no
Copy link
Contributor

kapi-no commented Feb 19, 2025

I think we should mention the partition layout changes in the changelog (breaking change).

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 19, 2025

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zrelease[nrf52820dongle/nrf52820]: ROM size increased by 5084[B] in comparison to the main[4f5484f] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zrelease[nrf52833dk/nrf52820]: ROM size increased by 5084[B] in comparison to the main[4f5484f] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52820dongle/nrf52820]: ROM size increased by 5344[B] in comparison to the main[4f5484f] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52810dmouse/nrf52810]: RAM size increased by 265[B] in comparison to the main[4f5484f] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52810dmouse/nrf52810]: ROM size increased by 9760[B] in comparison to the main[4f5484f] branch. - link (cc: @MarekPieta)
applications.nrf_desktop.zdebug[nrf52833dk/nrf52820]: ROM size increased by 5344[B] in comparison to the main[4f5484f] branch. - link (cc: @MarekPieta)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-20489/6)

Copy link
Contributor

@kapi-no kapi-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog can be added as a follow-up commit

@mkapala-nordic mkapala-nordic requested a review from a team as a code owner February 20, 2025 14:16
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 20, 2025
Copy link

github-actions bot commented Feb 20, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20489/nrf/releases_and_maturity/releases/release-notes-changelog.html

@mkapala-nordic mkapala-nordic force-pushed the upmerge/20241220/post-cleanup-fp-ns-targets-fix branch from d5392a8 to b7a4915 Compare February 20, 2025 14:17
Fixed the bt_fast_pair PM partition so it can be used together
with TF-M without issues.

Jira: NCSDK-31901
Jira: NCSDK-31777

Signed-off-by: Mateusz Kapala <mateusz.kapala@nordicsemi.no>
Changed TF-M profile from minimal to manually configured with
minimal feature set needed for the proper work of the
Bluetooth stack that uses PSA Crypto.

Jira: NCSDK-31777

Signed-off-by: Mateusz Kapala <mateusz.kapala@nordicsemi.no>
Changed TF-M profile from minimal to manually configured with
minimal feature set needed for the proper work of the
Bluetooth stack that uses PSA Crypto.
Changed pm_static files for nrf5340dk/nrf5340/cpuapp/ns
and thingy53/nrf5340/cpuapp/ns to accomodate needed
tfm_its partition and fix placement of bt_fast_pair partition.

Jira: NCSDK-31777

Signed-off-by: Mateusz Kapala <mateusz.kapala@nordicsemi.no>
@mkapala-nordic mkapala-nordic force-pushed the upmerge/20241220/post-cleanup-fp-ns-targets-fix branch from b7a4915 to 930ef53 Compare February 21, 2025 09:04
Added changelog related to fixing bt_fast_pair partition definition and
changes in the TF-M profile configuration in FP samples.

Jira: NCSDK-31901
Jira: NCSDK-31777

Signed-off-by: Mateusz Kapala <mateusz.kapala@nordicsemi.no>
@mkapala-nordic mkapala-nordic force-pushed the upmerge/20241220/post-cleanup-fp-ns-targets-fix branch from 930ef53 to 8b6e600 Compare February 21, 2025 09:05
@kapi-no kapi-no merged commit ef49118 into nrfconnect:main Feb 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants