Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm: Adds uninit for MPSL PM #20361

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

knutel-nordic
Copy link
Contributor

@knutel-nordic knutel-nordic commented Feb 14, 2025

mpsl: pm: Change init API and add uninit API MPSL PM

Refactor initialization API and add uninitialization.

Change the initialization API to do not allow call it
when it is already initialized or if uninitialization
is started but not completed. The uninitialization
API will wait for scheduled work queue uninit item
to complete. If that is late the API will timeout.

Uninitialize API will fail when the MPSL PM is not
in initialized state.

Unit tests are changed to cover changes in the API.

@knutel-nordic knutel-nordic requested review from a team as code owners February 14, 2025 06:29
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 14, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 14, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 208474b9481c485c1c9d423e35a483345d66ed8d

more details

sdk-nrf:

PR head: 208474b9481c485c1c9d423e35a483345d66ed8d
merge base: 34740f13c763ed222fc0b9d5a7fce3352c59a00b
target head (main): 34740f13c763ed222fc0b9d5a7fce3352c59a00b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (8)
include
│  ├── mpsl
│  │  │ mpsl_work.h
subsys
│  ├── mpsl
│  │  ├── init
│  │  │  │ mpsl_init.c
│  │  ├── pm
│  │  │  ├── Kconfig
│  │  │  ├── mpsl_pm_utils.c
│  │  │  │ mpsl_pm_utils.h
tests
│  ├── subsys
│  │  ├── mpsl
│  │  │  ├── pm
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── kernel_minimal_mock.h
│  │  │  │  │ pm_test.c

Outputs:

Toolchain

Version: 4cff34261a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4cff34261a_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 871
  • ✅ Integration tests
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-zigbee
    • ✅ test-sdk-find-my
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@ppryga-nordic ppryga-nordic force-pushed the mpsl_pm_uninit branch 2 times, most recently from 8eb3d98 to 06b775d Compare February 19, 2025 18:17
Copy link

github-actions bot commented Feb 20, 2025

After documentation is built, you will find the preview for this PR here.

Refactor initialization API and add uninitialization.

Change the initialization API to do not allow call it
when it is already initialized or if uninitialization
is started but not completed. The uninitialization
API will wait for scheduled work queue uninit item
to complete. If that is late the API will timeout.

Uninitialize API will fail when the MPSL PM is not
in initialized state.

Unit tests are changed to cover changes in the API.

Signed-off-by: Knut Eldhuset <knut.eldhuset@nordicsemi.no>
Signed-off-by: Piotr Pryga <piotr.pryga@nordicsemi.no>
Co-authored-by: Piotr Pryga <piotr.pryga@nordicsemi.no>
@ppryga-nordic ppryga-nordic removed their request for review February 20, 2025 22:03
@rlubos rlubos merged commit 693b886 into nrfconnect:main Feb 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants