Bluetooth: Enable C2H ACL data flow control by default #20208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 1067af7ecb5285f7d560ecf273d262fb1e71cd64 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: 4cff34261a Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
HaavardRei
previously approved these changes
Feb 10, 2025
HaavardRei
dismissed
their stale review
Seems some dependencies are needed in the direction finding samples?
PavelVPV
force-pushed
the
enable_c2h_acl_data_fc_by_default
branch
3 times, most recently
from
4c0ee57 to
7f55a97
Compare
nordicjm
reviewed
Feb 17, 2025
subsys/bluetooth/Kconfig
Outdated
Comment on lines
48
to
54
| if BT_CONN | ||
| config BT_HCI_ACL_FLOW_CONTROL | ||
| # Enabling this option by default for now to avoid potential deadlocks. See NCSDK-30959. | ||
| bool | ||
| default y | ||
| endif # BT_CONN |
There was a problem hiding this comment.
this says enable option, but I don't see it being used anywhere? If it already exists then fix:
if BT_CONN
config BT_HCI_ACL_FLOW_CONTROL
# Enabling this option by default for now to avoid potential deadlocks. See NCSDK-30959.
default y
endif # BT_CONN
7f55a97 to
a21ff40
Compare
github-actions
bot
added
doc-required
peknis
requested changes
Feb 18, 2025
Comment on lines
130
to
135
| * Fixed an issue where a flash operation executed on the system workqueue might result in ``-ETIMEDOUT``, if there is an active Bluetooth LE connection. | ||
| * Fixed an issue where Bluetooth applications built with the ``nordic-bt-rpc`` snippet (in the :ref:`ble_rpc` configuration) did not work on the nRF54H20 devices due to incorrect memory mapping. | ||
|
|
||
| * Updated: | ||
|
|
||
| * The kconfig option :kconfig:option:`CONFIG_BT_HCI_ACL_FLOW_CONTROL` to be enabled by default to mitigate risk of potential deadlocks in the Bluetooth Host. |
There was a problem hiding this comment.
Suggested change
| * Fixed an issue where a flash operation executed on the system workqueue might result in ``-ETIMEDOUT``, if there is an active Bluetooth LE connection. | |
| * Fixed an issue where Bluetooth applications built with the ``nordic-bt-rpc`` snippet (in the :ref:`ble_rpc` configuration) did not work on the nRF54H20 devices due to incorrect memory mapping. | |
| * Updated: | |
| * The kconfig option :kconfig:option:`CONFIG_BT_HCI_ACL_FLOW_CONTROL` to be enabled by default to mitigate risk of potential deadlocks in the Bluetooth Host. | |
| * Fixed: | |
| * An issue where a flash operation executed on the system workqueue might result in ``-ETIMEDOUT``, if there is an active Bluetooth LE connection. | |
| * An issue where Bluetooth applications built with the ``nordic-bt-rpc`` snippet (in the :ref:`ble_rpc` configuration) did not work on the nRF54H20 devices due to incorrect memory mapping. | |
| * Updated the :kconfig:option:`CONFIG_BT_HCI_ACL_FLOW_CONTROL` Kconfig option to be enabled by default to mitigate the risk of potential deadlocks in the Bluetooth Host. |
PavelVPV
force-pushed
the
enable_c2h_acl_data_fc_by_default
branch
3 times, most recently
from
a5355eb to
882df6d
Compare
This commit enables C2H ACL data flow control by default to avoid potential deadlocks. See NCSDK-30959 for details. Known issues are updated in a separate PR. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
Fix 'fixed' section in Bluetooth LE. This commit adds a note that C2H ACL FC is now enabled by default. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
This commit adds a note that C2H ACL FC is now enabled by default. Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
PavelVPV
force-pushed
the
enable_c2h_acl_data_fc_by_default
branch
from
882df6d to
1067af7
Compare
|
After documentation is built, you will find the preview for this PR here. Preview links for modified nRF Connect SDK documents: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables C2H ACL data flow control by default to avoid potential deadlocks. See NCSDK-30959 for details.
Known issues are updated in #20200.