-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_security: drivers: cracen: Add support for kmu push area to be defined from device tree. #19896
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 0b2f49259f104898b6e29ec364e592bd0caf802c more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)
Outputs:ToolchainVersion: 11349092be Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
…dtsi Currently kmu push area must be explicitly defined in linker script. With "zephyr,memory-region" it is possible to define this region in the device tree and then reference the node in kmu.c. Signed-off-by: Rob Robinson <robert.robinson@nordicsemi.no>
01a9dc2
to
0b2f492
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have two different ways of doing this.
One is in Zephyr:
https://github.com/nrfconnect/sdk-zephyr/blob/main/soc/nordic/nrf54l/kmu_push_area_section.ld
And one is in TF-M:
https://github.com/nrfconnect/sdk-trusted-firmware-m/blob/3f08f2595d976624e42478bb377cb24798b00a5d/platform/ext/common/gcc/tfm_common_s.ld#L290
I really don't want to add a third way of doing this, it makes the solution more error prone and if this doesn't work properly it will be a major issue.
I don't object using the dts for this but this needs to be at least universal for all devices in Zephyr.
I tried to use the reserved memory for the nRF54l15 use case as well but I could not make it work.
I propose to update the PR to use a linker file as well, the same way that we do it for nRF54l15. Then you can open a ticket to replace the linker files to DTS entries later.
Closing - Implemented by #20417 |
Currently kmu push area must be explicitly defined in linker script.
With "zephyr,memory-region" it is possible to define this
region in the device tree and reference the node in kmu.c.
Signed-off-by: Rob Robinson robert.robinson@nordicsemi.no