nrf_security: Add Cracen key derivation for SPAKE2P keys #19744

Vge0rge · 2025-01-03T14:32:03Z

Adds support for key derivation of SPAKE2P keys with Cracen. It currently supports only SECP256R1 keys.

Ref: NCSDK-30368

NordicBuilder · 2025-01-03T14:36:54Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 1ef07256aea087a7f665d8c13074309d8b8c408e

more details

sdk-nrf:

PR head: 1ef07256aea087a7f665d8c13074309d8b8c408e
merge base: ca3e7af8fee049a2b5543cc35a0869546a709d53
target head (main): 7ab99c837804a65140f23f3960c1cfff1f523ef2
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (5)

subsys
│  ├── nrf_security
│  │  ├── src
│  │  │  ├── drivers
│  │  │  │  ├── cracen
│  │  │  │  │  ├── cracenpsa
│  │  │  │  │  │  ├── include
│  │  │  │  │  │  │  │ cracen_psa.h
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  ├── common.c
│  │  │  │  │  │  │  ├── common.h
│  │  │  │  │  │  │  │ key_management.c
│  │  │  │ psa_crypto_driver_wrappers.c

Outputs:

Toolchain

Version: 4cff34261a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4cff34261a_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
❌ Build twister
- sdk-nrf test count: 1710
❌ Integration tests
- ❌ test-fw-nrfconnect-chip
- ❌ test-fw-nrfconnect-nrf-iot_cloud
- ❌ test-fw-nrfconnect-nrf_crypto
- ❌ test-fw-nrfconnect-tfm
- ❌ test-sdk-find-my
- ❌ test-sdk-sidewalk
- ❌ test-sdk-dfu

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

subsys/nrf_security/src/psa_crypto_driver_wrappers.c

subsys/nrf_security/src/drivers/cracen/cracenpsa/src/key_management.c

subsys/nrf_security/src/drivers/cracen/cracenpsa/src/common.h

Damian-Nordic · 2025-01-22T09:43:50Z

I tested this change and tried to generate Spake2+ verifier for the following parameters:

salt: 5350414b453250204b65792053616c74
iteration count: 1000
passcode: 20202021 (encoded as 32-bit little-endian integer)

The outcome should be:

b96170aae803346884724fe9a3b287c30330c2a660375d17bb205a8cf1aecb350457f8ab79ee253ab6a8e46bb09e543ae422736de501e3db37d441fe344920d09548e4c18240630c4ff4913c53513839b7c07fcc0627a1b8573a149fcd1fa466cf

I get this result on nRF52 + Oberon, but on nRF54L with this PR I get:

E: Verifier
E: 2c 01 00 00 a0 0f 00 20 |,...... 
E: f4 01 00 00 2c 01 00 00 |....,...
E: a0 0f 00 20 00 00 00 00 |... ....
E: 78 3a 00 20 08 3f 01 20 |x:. .?. 
E: 9d 3f 06 00 18 00 00 00 |.?......
E: 38 37 01 20 ff 00 00 00 |87. ....
E: 38 37 01 20 38 37 01 20 |87. 87. 
E: 57 26 06 00 00 00 00 00 |W&......
E: 20 ea 00 20 a0 e8 00 20 | .. ... 
E: 35 13 05 00 a0 e8 00 20 |5...... 
E: a4 7a 01 20 c1 fd 08 00 |.z. ....
E: a3 03 05 00 00 00 00 00 |........
E: 00                      |.       
E: Exited with code 0

EDIT: Ah, I forgot to check the return value from psa_export_public_key in my test. Thus, it seems exporting the SPAKE2P public key (verifier) is not yet implemented by this PR.

Vge0rge · 2025-01-23T11:54:12Z

I tested this change and tried to generate Spake2+ verifier for the following parameters:

salt: 5350414b453250204b65792053616c74

iteration count: 1000

passcode: 20202021 (encoded as 32-bit little-endian integer)

The outcome should be:
b96170aae803346884724fe9a3b287c30330c2a660375d17bb205a8cf1aecb350457f8ab79ee253ab6a8e46bb09e543ae422736de501e3db37d441fe344920d09548e4c18240630c4ff4913c53513839b7c07fcc0627a1b8573a149fcd1fa466cf
I get this result on nRF52 + Oberon, but on nRF54L with this PR I get:
E: Verifier
E: 2c 01 00 00 a0 0f 00 20 |,...... 
E: f4 01 00 00 2c 01 00 00 |....,...
E: a0 0f 00 20 00 00 00 00 |... ....
E: 78 3a 00 20 08 3f 01 20 |x:. .?. 
E: 9d 3f 06 00 18 00 00 00 |.?......
E: 38 37 01 20 ff 00 00 00 |87. ....
E: 38 37 01 20 38 37 01 20 |87. 87. 
E: 57 26 06 00 00 00 00 00 |W&......
E: 20 ea 00 20 a0 e8 00 20 | .. ... 
E: 35 13 05 00 a0 e8 00 20 |5...... 
E: a4 7a 01 20 c1 fd 08 00 |.z. ....
E: a3 03 05 00 00 00 00 00 |........
E: 00                      |.       
E: Exited with code 0
EDIT: Ah, I forgot to check the return value from psa_export_public_key in my test. Thus, it seems exporting the SPAKE2P public key (verifier) is not yet implemented by this PR.

Thanks for the feedback! We have another task for the export_public_key function but it might make sense to just do it here for completeness. Did you check if the derive_key function gives you the correct result from this function?

Adds support for key derivation of SPAKE2P keys with Cracen. It currently supports only SECP256R1 keys. Ref: NCSDK-30368 Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>

tomi-font · 2025-02-04T13:27:44Z

subsys/nrf_security/src/drivers/cracen/cracenpsa/src/key_management.c

@@ -471,6 +471,59 @@ static psa_status_t import_spake2p_key(const psa_key_attributes_t *attributes, c
 	return PSA_SUCCESS;
 }

+static psa_status_t cracen_derive_spake2p_key(const psa_key_attributes_t *attributes, const uint8_t *input,


degjorva · 2025-02-18T16:07:05Z

@Damian-Nordic We have added support for psa_export_public_key. Please test it when you have the time

Damian-Nordic · 2025-02-18T23:29:48Z

@Damian-Nordic We have added support for psa_export_public_key. Please test it when you have the time

Hmm. Somehow it's not working but I'll debug it. What's strange is that I get no error despite of returning no output because of this if:


	psa_status = cracen_ecc_get_ecurve_from_psa(psa_curve, key_bits_attr, &sx_curve);
	if (psa_status != PSA_SUCCESS) {
		return PSA_SUCCESS;
	}

This doesn't look right, no? :)

Add support for export of SPAKE2P keys to Cracen. It currently only supports SECP256R1 keys. Signed-off-by: Dag Erik Gjørvad <dag.erik.gjorvad@nordicsemi.no>

degjorva · 2025-02-20T16:38:41Z

@Damian-Nordic We have added support for psa_export_public_key. Please test it when you have the time

Hmm. Somehow it's not working but I'll debug it. What's strange is that I get no error despite of returning no output because of this if:
	psa_status = cracen_ecc_get_ecurve_from_psa(psa_curve, key_bits_attr, &sx_curve);
	if (psa_status != PSA_SUCCESS) {
		return PSA_SUCCESS;
	}
This doesn't look right, no? :)

Ahaha, no, that has been in there for quite a while it seems. Updated it. Found the issue that caused it to be supposed to throw an error to begin with. Please try it again when you have the chance

Damian-Nordic · 2025-02-21T11:45:13Z

Ahaha, no, that has been in there for quite a while it seems. Updated it. Found the issue that caused it to be supposed to throw an error to begin with. Please try it again when you have the chance

I checked that the Spake2+ private key derivation works correctly but public key needs a bit more work.

You used generic export_ecc_public_key_from_keypair function which seems to treat Spake2+ private key as ECDSA private key and it produces 65B public key (a single ECC point).
Note that the Spake2+ private key consists of not one but two group exponents (w0 and w1) which gives 64B in total, and the public key consists of w0 and L (where L is g*w1), which gives 32+65B in total. Thus, I think if export_ecc_public_key_from_keypair can be used, it should be given only w1 part of the private key and w0 should be just prepended to the result.

But I can approve the PR if you would prefer to first merge the private key part :)

Vge0rge requested a review from a team as a code owner January 3, 2025 14:32

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 3, 2025

degjorva approved these changes Jan 9, 2025

View reviewed changes

tomi-font reviewed Jan 10, 2025

View reviewed changes

Vge0rge force-pushed the derive_pake_cracen branch from e925800 to 99fcf77 Compare February 3, 2025 13:12

nrf_security: Add Cracen key derivation for SPAKE2P keys

78004d0

Adds support for key derivation of SPAKE2P keys with Cracen. It currently supports only SECP256R1 keys. Ref: NCSDK-30368 Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>

Vge0rge force-pushed the derive_pake_cracen branch from 99fcf77 to 78004d0 Compare February 3, 2025 13:35

tomi-font approved these changes Feb 4, 2025

View reviewed changes

degjorva force-pushed the derive_pake_cracen branch from 8e48b11 to addc07a Compare February 10, 2025 11:01

nrf_security: drivers: cracen: Add Cracen key export for SPAKE2P keys

1ef0725

Add support for export of SPAKE2P keys to Cracen. It currently only supports SECP256R1 keys. Signed-off-by: Dag Erik Gjørvad <dag.erik.gjorvad@nordicsemi.no>

degjorva force-pushed the derive_pake_cracen branch from addc07a to 1ef0725 Compare February 21, 2025 08:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nrf_security: Add Cracen key derivation for SPAKE2P keys #19744

nrf_security: Add Cracen key derivation for SPAKE2P keys #19744

Vge0rge commented Jan 3, 2025

NordicBuilder commented Jan 3, 2025 •

edited

Loading

Damian-Nordic commented Jan 22, 2025 •

edited

Loading

Vge0rge commented Jan 23, 2025

tomi-font Feb 4, 2025

degjorva commented Feb 18, 2025

Damian-Nordic commented Feb 18, 2025

degjorva commented Feb 20, 2025

Damian-Nordic commented Feb 21, 2025

nrf_security: Add Cracen key derivation for SPAKE2P keys #19744

Are you sure you want to change the base?

nrf_security: Add Cracen key derivation for SPAKE2P keys #19744

Conversation

Vge0rge commented Jan 3, 2025

NordicBuilder commented Jan 3, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Damian-Nordic commented Jan 22, 2025 • edited Loading

Vge0rge commented Jan 23, 2025

tomi-font Feb 4, 2025

Choose a reason for hiding this comment

degjorva commented Feb 18, 2025

Damian-Nordic commented Feb 18, 2025

degjorva commented Feb 20, 2025

Damian-Nordic commented Feb 21, 2025

NordicBuilder commented Jan 3, 2025 •

edited

Loading

Damian-Nordic commented Jan 22, 2025 •

edited

Loading