Add in-memory session store for drawbridge #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good on a quick skim. I'd love to get a +1 from one other person before merging and releasing...? |
|
Anyone!!? |
|
@sritchie I'll merge, then push a SNAPSHOT release. If you could then +1 using it, then I'll cut a proper release. Maybe you'd like to pick up this project, too? I put it together largely as a proof of concept, but I don't actually have a use for it; if you do, better for you to maintain it than whatever it is I'm doing. ;-) |
|
@sritchie This is now available in |
|
Okay, will try soon and get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15, and #11. This pull req adds an in-memory store wrapper with a different default key. The session that Drawbridge sets gets slurped up by the in-memory store, which sets a cookie. Any session middleware further up the chain won't see the non-serializable nREPL session values, and higher middleware such as Friend are free to set whatever keys they want in the standard, user-specified session.