Fix the asgi handler's scope argument type (strawberry-graphql#3581)

nrbnlulu · Jul 31, 2024 · 7818c39 · 7818c39
1 parent 6415e67
commit 7818c39
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -0,0 +1,3 @@
+Release type: patch
+
+This release fixes the type of the ASGI request handler's `scope` argument, making type checkers ever so slightly happier.
diff --git a/strawberry/asgi/__init__.py b/strawberry/asgi/__init__.py
@@ -117,12 +117,12 @@ def __init__(
         else:
             self.graphql_ide = graphql_ide
 
-    async def __call__(self, scope: Request, receive: Receive, send: Send) -> None:
+    async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None:
         if scope["type"] == "http":
-            return await self.handle_http(scope, receive, send)  # type: ignore
+            return await self.handle_http(scope, receive, send)
 
         elif scope["type"] == "websocket":
-            ws = WebSocket(scope, receive=receive, send=send)  # type: ignore
+            ws = WebSocket(scope, receive=receive, send=send)
             preferred_protocol = self.pick_preferred_protocol(ws)
 
             if preferred_protocol == GRAPHQL_TRANSPORT_WS_PROTOCOL: