Skip to content

Commit

Permalink
fix: do not collapse chores for now
Browse files Browse the repository at this point in the history
  • Loading branch information
@lukekarrys
lukekarrys committed Dec 5, 2023
1 parent 8ff563d commit c0c95bf
Show file tree
Hide file tree
Showing 9 changed files with 387 additions and 661 deletions.
2 changes: 2 additions & 0 deletions lib/release/changelog.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ class Changelog {
#getEntries (type) {
const section = this.#sections[type]
const entries = this.#entries[type].map(list)
// Ignoring coverage until we use this again
/* istanbul ignore next */
if (section?.collapse) {
entries.unshift('<details><summary>Commits</summary>\n')
entries.push('\n</details>')
Expand Down
40 changes: 19 additions & 21 deletions tap-snapshots/test/release/release-please-cases-chore-commit.js.test.cjs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,15 @@ Object {
---
<details><summary>2016.0.2-pre</summary>
<details><summary>2017.0.3-pre</summary>
## [2016.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.1-pre...v2016.0.2-pre) (2023-12-04)
## [2017.0.3-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.2-pre...v2017.0.3-pre) (2023-12-05)
### Chores
<details><summary>Commits</summary>
* [\`d690bcb\`](https://github.com/npm/npm-cli-release-please/commit/d690bcb622f954314086bc333cd56fa4d2b59897) this is a chore (@lukekarrys)
* [\`38acd0f\`](https://github.com/npm/npm-cli-release-please/commit/38acd0f850907c357e51caa56faa42526ace49d9) update template-oss (@lukekarrys)
* [\`f936a4b\`](https://github.com/npm/npm-cli-release-please/commit/f936a4be5f739048163b8346568f8bc49b7b53f9) this is a chore (@lukekarrys)
</details>
</details>
Expand All @@ -35,40 +34,39 @@ Object {
"labels": Array [
"autorelease: pending",
],
"number": 264,
"sha": "675ff2fa3a03500ce5748e38d05c003d80943e43",
"title": "chore: release 2016.0.2-pre",
"number": 268,
"sha": "9e96e7aa386e69fd38783b037402d2ffd64fb5fc",
"title": "chore: release 2017.0.3-pre",
}
`

exports[`test/release/release-please.js TAP cases chore commit > releases chore commit 1`] = `
Array [
Object {
"draft": false,
"id": 132552731,
"major": 2016,
"id": 132694534,
"major": 2017,
"minor": 0,
"name": "v2016.0.2-pre",
"name": "v2017.0.3-pre",
"notes": String(
## [2016.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.1-pre...v2016.0.2-pre) (2023-12-04)
## [2017.0.3-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.2-pre...v2017.0.3-pre) (2023-12-05)
### Chores
Commits
* [\`d690bcb\`](https://github.com/npm/npm-cli-release-please/commit/d690bcb622f954314086bc333cd56fa4d2b59897) this is a chore (@lukekarrys)
* [\`38acd0f\`](https://github.com/npm/npm-cli-release-please/commit/38acd0f850907c357e51caa56faa42526ace49d9) update template-oss (@lukekarrys)
* [\`f936a4b\`](https://github.com/npm/npm-cli-release-please/commit/f936a4be5f739048163b8346568f8bc49b7b53f9) this is a chore (@lukekarrys)
),
"patch": 2,
"patch": 3,
"path": ".",
"pkgName": "npm-cli-release-please",
"prNumber": 264,
"publishTag": "prerelease-2016",
"sha": "eaa230680541215efd72568054f187e8cebdd2a5",
"tagName": "v2016.0.2-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552731/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2016.0.2-pre",
"version": "2016.0.2-pre",
"prNumber": 268,
"publishTag": "prerelease-2017",
"sha": "13b89ef2a76c624b3ebccda40ee817c4112744fc",
"tagName": "v2017.0.3-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694534/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2017.0.3-pre",
"version": "2017.0.3-pre",
},
]
`
498 changes: 169 additions & 329 deletions tap-snapshots/test/release/release-please-cases-fix-all.js.test.cjs
View file

Large diffs are not rendered by default.

192 changes: 71 additions & 121 deletions tap-snapshots/test/release/release-please-cases-fix-one.js.test.cjs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,71 +13,45 @@ Object {
---
<details><summary>2016.0.1-pre</summary>
<details><summary>2017.0.2-pre</summary>
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.0-pre...v2016.0.1-pre) (2023-12-04)
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.1-pre...v2017.0.2-pre) (2023-12-05)
### Bug Fixes
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
* [\`c9eaf9c\`](https://github.com/npm/npm-cli-release-please/commit/c9eaf9c0e8943bef862e7695a9e0c7d083731ee4) update pkg3 (@lukekarrys)
### Dependencies
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre): \`pkg1@2016.0.1-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`pkg2@2016.0.1-pre\`
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.0-pre...v2016.0.1-pre) (2023-12-04)
### Bug Fixes
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
### Dependencies
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre): \`pkg1@2016.0.1-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`pkg2@2016.0.1-pre\`
### Chores
<details><summary>Commits</summary>
* [\`4646ee6\`](https://github.com/npm/npm-cli-release-please/commit/4646ee6c12c10646732418f6244a671d2ddac2cf) update template-oss (@lukekarrys)
</details>
### Chores
<details><summary>Commits</summary>
* [\`4646ee6\`](https://github.com/npm/npm-cli-release-please/commit/4646ee6c12c10646732418f6244a671d2ddac2cf) update template-oss (@lukekarrys)
</details>
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2017.0.2-pre): \`pkg1@2017.0.2-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre): \`pkg2@2017.0.2-pre\`
</details>
<details><summary>pkg1: 2016.0.1-pre</summary>
<details><summary>pkg1: 2017.0.2-pre</summary>
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2016.0.0-pre...pkg1-v2016.0.1-pre) (2023-12-04)
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2017.0.1-pre...pkg1-v2017.0.2-pre) (2023-12-05)
### Dependencies
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`pkg2@2016.0.1-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre): \`pkg2@2017.0.2-pre\`
</details>
<details><summary>pkg2: 2016.0.1-pre</summary>
<details><summary>pkg2: 2017.0.2-pre</summary>
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2016.0.0-pre...pkg2-v2016.0.1-pre) (2023-12-04)
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2017.0.1-pre...pkg2-v2017.0.2-pre) (2023-12-05)
### Dependencies
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2016.0.1-pre): \`@npmcli/pkg3@2016.0.1-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2017.0.2-pre): \`@npmcli/pkg3@2017.0.2-pre\`
</details>
<details><summary>pkg3: 2016.0.1-pre</summary>
<details><summary>pkg3: 2017.0.2-pre</summary>
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2016.0.0-pre...pkg3-v2016.0.1-pre) (2023-12-04)
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2017.0.1-pre...pkg3-v2017.0.2-pre) (2023-12-05)
### Bug Fixes
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
* [\`c9eaf9c\`](https://github.com/npm/npm-cli-release-please/commit/c9eaf9c0e8943bef862e7695a9e0c7d083731ee4) update pkg3 (@lukekarrys)
</details>
---
Expand All @@ -88,138 +62,114 @@ Object {
"labels": Array [
"autorelease: pending",
],
"number": 263,
"sha": "bd4c9b0771b575fc993a70bdfda26392c5aebf3a",
"title": "chore: release 2016.0.1-pre",
"number": 267,
"sha": "b3ff3a8d68d6bab0d83fd82ba0bd260ebe296bb8",
"title": "chore: release 2017.0.2-pre",
}
`

exports[`test/release/release-please.js TAP cases fix one > releases fix one 1`] = `
Array [
Object {
"draft": false,
"id": 132552599,
"major": 2016,
"id": 132694353,
"major": 2017,
"minor": 0,
"name": "v2016.0.1-pre",
"name": "v2017.0.2-pre",
"notes": String(
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.0-pre...v2016.0.1-pre) (2023-12-04)
### Bug Fixes
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
### Dependencies
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre): \`pkg1@2016.0.1-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`pkg2@2016.0.1-pre\`
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.0-pre...v2016.0.1-pre) (2023-12-04)
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.1-pre...v2017.0.2-pre) (2023-12-05)
### Bug Fixes
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
* [\`c9eaf9c\`](https://github.com/npm/npm-cli-release-please/commit/c9eaf9c0e8943bef862e7695a9e0c7d083731ee4) update pkg3 (@lukekarrys)
### Dependencies
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre): \`pkg1@2016.0.1-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`pkg2@2016.0.1-pre\`
### Chores
Commits
* [\`4646ee6\`](https://github.com/npm/npm-cli-release-please/commit/4646ee6c12c10646732418f6244a671d2ddac2cf) update template-oss (@lukekarrys)
### Chores
Commits
* [\`4646ee6\`](https://github.com/npm/npm-cli-release-please/commit/4646ee6c12c10646732418f6244a671d2ddac2cf) update template-oss (@lukekarrys)
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2017.0.2-pre): \`pkg1@2017.0.2-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre): \`pkg2@2017.0.2-pre\`
),
"patch": 1,
"patch": 2,
"path": ".",
"pkgName": "npm-cli-release-please",
"prNumber": 263,
"publishTag": "prerelease-2016",
"sha": "20a9a74e0872e79d47acf300a00701bb706b801e",
"tagName": "v2016.0.1-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552599/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2016.0.1-pre",
"version": "2016.0.1-pre",
"prNumber": 267,
"publishTag": "prerelease-2017",
"sha": "e4738bce93b7a2d58c2fee7b618971b5b0feb4bc",
"tagName": "v2017.0.2-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694353/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2017.0.2-pre",
"version": "2017.0.2-pre",
},
Object {
"draft": false,
"id": 132552602,
"major": 2016,
"id": 132694359,
"major": 2017,
"minor": 0,
"name": "pkg1: v2016.0.1-pre",
"name": "pkg1: v2017.0.2-pre",
"notes": String(
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2016.0.0-pre...pkg1-v2016.0.1-pre) (2023-12-04)
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg1-v2017.0.1-pre...pkg1-v2017.0.2-pre) (2023-12-05)
### Dependencies
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre): \`pkg2@2016.0.1-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre): \`pkg2@2017.0.2-pre\`
),
"patch": 1,
"patch": 2,
"path": "pkg1",
"pkgName": "pkg1",
"prNumber": 263,
"publishTag": "prerelease-2016",
"sha": "20a9a74e0872e79d47acf300a00701bb706b801e",
"tagName": "pkg1-v2016.0.1-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552602/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2016.0.1-pre",
"version": "2016.0.1-pre",
"prNumber": 267,
"publishTag": "prerelease-2017",
"sha": "e4738bce93b7a2d58c2fee7b618971b5b0feb4bc",
"tagName": "pkg1-v2017.0.2-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694359/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg1-v2017.0.2-pre",
"version": "2017.0.2-pre",
},
Object {
"draft": false,
"id": 132552604,
"major": 2016,
"id": 132694369,
"major": 2017,
"minor": 0,
"name": "pkg2: v2016.0.1-pre",
"name": "pkg2: v2017.0.2-pre",
"notes": String(
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2016.0.0-pre...pkg2-v2016.0.1-pre) (2023-12-04)
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg2-v2017.0.1-pre...pkg2-v2017.0.2-pre) (2023-12-05)
### Dependencies
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2016.0.1-pre): \`@npmcli/pkg3@2016.0.1-pre\`
* [workspace](https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2017.0.2-pre): \`@npmcli/pkg3@2017.0.2-pre\`
),
"patch": 1,
"patch": 2,
"path": "pkg2",
"pkgName": "pkg2",
"prNumber": 263,
"publishTag": "prerelease-2016",
"sha": "20a9a74e0872e79d47acf300a00701bb706b801e",
"tagName": "pkg2-v2016.0.1-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552604/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2016.0.1-pre",
"version": "2016.0.1-pre",
"prNumber": 267,
"publishTag": "prerelease-2017",
"sha": "e4738bce93b7a2d58c2fee7b618971b5b0feb4bc",
"tagName": "pkg2-v2017.0.2-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694369/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg2-v2017.0.2-pre",
"version": "2017.0.2-pre",
},
Object {
"draft": false,
"id": 132552609,
"major": 2016,
"id": 132694374,
"major": 2017,
"minor": 0,
"name": "pkg3: v2016.0.1-pre",
"name": "pkg3: v2017.0.2-pre",
"notes": String(
## [2016.0.1-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2016.0.0-pre...pkg3-v2016.0.1-pre) (2023-12-04)
## [2017.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/pkg3-v2017.0.1-pre...pkg3-v2017.0.2-pre) (2023-12-05)
### Bug Fixes
* [\`7e91b91\`](https://github.com/npm/npm-cli-release-please/commit/7e91b91c370ccd64ec8af6d16cb9601a7df1e793) update pkg3 (@lukekarrys)
* [\`c9eaf9c\`](https://github.com/npm/npm-cli-release-please/commit/c9eaf9c0e8943bef862e7695a9e0c7d083731ee4) update pkg3 (@lukekarrys)
),
"patch": 1,
"patch": 2,
"path": "pkg3",
"pkgName": "@npmcli/pkg3",
"prNumber": 263,
"publishTag": "prerelease-2016",
"sha": "20a9a74e0872e79d47acf300a00701bb706b801e",
"tagName": "pkg3-v2016.0.1-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552609/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2016.0.1-pre",
"version": "2016.0.1-pre",
"prNumber": 267,
"publishTag": "prerelease-2017",
"sha": "e4738bce93b7a2d58c2fee7b618971b5b0feb4bc",
"tagName": "pkg3-v2017.0.2-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694374/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/pkg3-v2017.0.2-pre",
"version": "2017.0.2-pre",
},
]
`
Loading

0 comments on commit c0c95bf

Please sign in to comment.