Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for Amazon Aurora DSQL #3396

Open
GunboatDiplomat opened this issue Dec 4, 2024 · 2 comments
Open

Add compatibility for Amazon Aurora DSQL #3396

GunboatDiplomat opened this issue Dec 4, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@GunboatDiplomat
Copy link

GunboatDiplomat commented Dec 4, 2024

DSQL has a large subset of Postgres features. It's compatible with Npgsql as noted here
https://docs.aws.amazon.com/aurora-dsql/latest/userguide/SECTION_program-with-net.html

It would be nice if we could have a compatibility flag that makes EF avoid unsupported SQL. It's possible that everything already works, but I can not confirm that for all cases, this is the list of unsupported Postgres features:
https://docs.aws.amazon.com/aurora-dsql/latest/userguide/working-with-postgresql-compatibility-unsupported-features.html

@GunboatDiplomat GunboatDiplomat changed the title Add compatibly for Amazon Aurora DSQL Add compatibility for Amazon Aurora DSQL Dec 4, 2024
@roji
Copy link
Member

roji commented Dec 5, 2024

@GunboatDiplomat I wouldn't be against a config switch that tells the provider that Aurora is being targeted, which would affect the kind of SQL that gets generated. But somehow would have to put in the work to identify exactly what needs to be done, test things, etc. etc.

In addition, for e.g. foreign keys (which aren't supported), dotnet/efcore#15854 is likely needed. There may be other things that would require EF-side changes.

@roji roji added the enhancement New feature or request label Dec 5, 2024
@roji roji added this to the Backlog milestone Dec 5, 2024
@GunboatDiplomat
Copy link
Author

Thanks @roji for the update. If I understood correctly, foreign keys would only be an issue with navigation properties and code migrations in EF, so that's not a blocker (at least it isn't for my use case). I guess the next step would be to run all tests against Aurora DSQL and see how compatible the current situation is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants