Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Update .source and quota-throttler tests #6627

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

SokratisVidros
Copy link
Contributor

@SokratisVidros SokratisVidros commented Oct 4, 2024

What changed? Why was the change needed?

Add "error" key to payload so that all published @novu/framework versions treat it as a platform error and prints it nicely in Bridge Endpoint logs.

See:

return !!err && typeof err === 'object' && 'error' in err && 'message' in err && 'statusCode' in err;

} else if (checkIsResponseError(resJson)) {

Before the fix, 402 was convert to a 500 error:

...
 GET /api/novu?action=discover 200 in 4ms
y [Error]: Something went wrong. Please try again later.
    at Object.post (webpack-internal:///(rsc)/./node_modules/@novu/framework/dist/servers/next.js:23:5386)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async eval (webpack-internal:///(rsc)/./node_modules/@novu/framework/dist/servers/next.js:27:4757)
    at async Re.handleAction (webpack-internal:///(rsc)/./node_modules/@novu/framework/dist/servers/next.js:27:3949)
    at async eval (webpack-internal:///(rsc)/./node_modules/@novu/framework/dist/servers/next.js:27:2841)
    at async /Users/foo/my-novu-app/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:55759
    at async eO.execute (/Users/foo/my-novu-app/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:46527)
    at async eO.handle (/Users/foo/my-novu-app/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:57093)
    at async doRender (/Users/foo/my-novu-app/node_modules/next/dist/server/base-server.js:1345:42)
    at async cacheEntry.responseCache.get.routeKind (/Users/foo/my-novu-app/node_modules/next/dist/server/base-server.js:1567:28)
    at async DevServer.renderToResponseWithComponentsImpl (/Users/foo/my-novu-app/node_modules/next/dist/server/base-server.js:1475:28)
    at async DevServer.renderPageComponent (/Users/foo/my-novu-app/node_modules/next/dist/server/base-server.js:1901:24)
    at async DevServer.renderToResponseImpl (/Users/foo/my-novu-app/node_modules/next/dist/server/base-server.js:1939:32)
    at async DevServer.pipeImpl (/Users/foo/my-novu-app/node_modules/next/dist/server/base-server.js:914:25)
    at async NextNodeServer.handleCatchallRenderRequest (/Users/foo/my-novu-app/node_modules/next/dist/server/next-server.js:272:17)
    at async DevServer.handleRequestImpl (/Users/foo/my-novu-app/node_modules/next/dist/server/base-server.js:810:17)
    at async /Users/foo/my-novu-app/node_modules/next/dist/server/dev/next-dev-server.js:339:20
    at async Span.traceAsyncFn (/Users/foo/my-novu-app/node_modules/next/dist/trace/trace.js:154:20)
    at async DevServer.handleRequest (/Users/foo/my-novu-app/node_modules/next/dist/server/dev/next-dev-server.js:336:24)
    at async invokeRender (/Users/foo/my-novu-app/node_modules/next/dist/server/lib/router-server.js:173:21)
    at async handleRequest (/Users/foo/my-novu-app/node_modules/next/dist/server/lib/router-server.js:350:24)
    at async requestHandlerImpl (/Users/foo/my-novu-app/node_modules/next/dist/server/lib/router-server.js:374:13)
    at async Server.requestListener (/Users/foo/my-novu-app/node_modules/next/dist/server/lib/start-server.js:141:13) {
  data: undefined,
  statusCode: 500,
  code: 'BridgeError'
}
...

Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 1a68276
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/66fff8ec305a30000839b1ca
😎 Deploy Preview https://deploy-preview-6627--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rifont rifont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@SokratisVidros SokratisVidros merged commit 172d172 into next Oct 4, 2024
23 checks passed
@SokratisVidros SokratisVidros deleted the treat_402_as_a_platform_error branch October 4, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants