chore(root): Prevent multi-level imports for @novu/* packages (#6596)

apps/api/src/app/testing/billing/create-usage-records.e2e-ee.ts

@@ -3,6 +3,7 @@ import { Logger } from '@nestjs/common';
 import sinon from 'sinon';
 import { expect } from 'chai';
 import { ApiServiceLevelEnum } from '@novu/shared';
+// eslint-disable-next-line no-restricted-imports
 import { StripeBillingIntervalEnum, StripeUsageTypeEnum } from '@novu/ee-billing/src/stripe/types';
 import { GetFeatureFlag } from '@novu/application-generic';
 

apps/api/src/app/testing/billing/get-prices.e2e-ee.ts

@@ -2,6 +2,7 @@
 import sinon from 'sinon';
 import { expect } from 'chai';
 import { ApiServiceLevelEnum } from '@novu/shared';
+// eslint-disable-next-line no-restricted-imports
 import { StripeBillingIntervalEnum } from '@novu/ee-billing/src/stripe/types';
 
 describe('GetPrices', () => {

apps/api/src/app/testing/billing/upsert-setup-intent.e2e-ee.ts

@@ -2,6 +2,7 @@
 import sinon from 'sinon';
 import { expect } from 'chai';
 import { ApiServiceLevelEnum } from '@novu/shared';
+// eslint-disable-next-line no-restricted-imports
 import { StripeBillingIntervalEnum } from '@novu/ee-billing/src/stripe/types';
 
 describe('Upsert setup intent', () => {

apps/api/src/app/testing/billing/upsert-subscription.e2e-ee.ts

@@ -3,6 +3,7 @@ import sinon from 'sinon';
 import { CommunityOrganizationRepository, IntegrationRepository } from '@novu/dal';
 import { expect } from 'chai';
 import { ApiServiceLevelEnum } from '@novu/shared';
+// eslint-disable-next-line no-restricted-imports
 import { StripeBillingIntervalEnum, StripeUsageTypeEnum } from '@novu/ee-billing/src/stripe/types';
 
 describe('UpsertSubscription', () => {

apps/api/src/app/testing/billing/webhook.e2e-ee.ts

@@ -2,6 +2,7 @@
 import sinon from 'sinon';
 import { expect } from 'chai';
 import { ApiServiceLevelEnum } from '@novu/shared';
+// eslint-disable-next-line no-restricted-imports
 import { StripeBillingIntervalEnum } from '@novu/ee-billing/src/stripe/types';
 import { GetFeatureFlag } from '@novu/application-generic';
 

apps/web/src/components/layout/components/ListPage.tsx

@@ -1,6 +1,5 @@
 import styled from '@emotion/styled';
-import { IPaginationProps, PageContainer, Pagination, colors } from '@novu/design-system';
-import { ITableProps } from '@novu/design-system/dist/types/table/Table';
+import { IPaginationProps, PageContainer, Pagination, colors, ITableProps } from '@novu/design-system';
 import { ComponentProps, PropsWithChildren } from 'react';
 import PageHeader from './PageHeader';
 

eslint.config.mjs

@@ -29,6 +29,26 @@ import { FlatCompat } from '@eslint/eslintrc';
 
 const compat = new FlatCompat({ baseDirectory: import.meta.dirname });
 
+/**
+ * REUSED RULE CONFIGURATIONS
+ *
+ * This is necessary because Eslint doesn't merge rule configurations
+ * when they are targeting different paths.
+ */
+
+/**
+ * This rule ensures that "multi-level" imports are not used for `@novu/*` packages.
+ */
+const noRestrictedImportsMultiLevelNovuPattern = {
+  group: [
+    '@novu/*/**/*',
+    // These packages have legitimate exports 1 path part below the root level
+    // This flatMap logic ignores the path 1 below the root level and prevents deeper imports.
+    ...['framework', 'js', 'novui'].flatMap((pkg) => [`!@novu/${pkg}/**/*`, `@novu/${pkg}/*/**/*`]),
+  ],
+  message: "Please import only from the root package entry point. For example, use 'import { Client } from '@novu/node';' instead of 'import { Client } from '@novu/node/src';'",
+};
+
 export default tsEslint.config(
   /* ******************** RECOMMENDED CONFIG ******************** */
   jsEslint.configs.recommended,
@@ -155,12 +175,7 @@ export default tsEslint.config(
         'error',
         {
           patterns: [
-            '@novu/shared/*',
-            '!@novu/shared/utils',
-            '@novu/dal/*',
-            '*../libs/dal/*',
-            '*../packages/shared/*',
-            '*../libs/stateless/*',
+            noRestrictedImportsMultiLevelNovuPattern,
           ],
         },
       ],
@@ -275,6 +290,7 @@ export default tsEslint.config(
         'error',
         {
           patterns: [
+            noRestrictedImportsMultiLevelNovuPattern,
             {
               /**
                * This rule ensures that the overridden Swagger decorators are used,

libs/design-system/src/table/index.ts

@@ -1,3 +1,3 @@
 export { Table } from './Table';
-export type { IExtendedColumn, IExtendedCellProps, IRow } from './Table';
+export type { IExtendedColumn, IExtendedCellProps, IRow, ITableProps } from './Table';
 export { withCellLoading } from './withCellLoading';

packages/node/src/lib/novu.ts

@@ -1,5 +1,5 @@
 import axios, { AxiosInstance } from 'axios';
-import { getEnvVariable } from '@novu/shared/utils';
+import { getEnvVariable } from '@novu/shared';
 import { EventEmitter } from 'events';
 import { Subscribers } from './subscribers/subscribers';
 import { Changes } from './changes/changes';

packages/notification-center-vue/src/index.ts

@@ -1,5 +1,6 @@
 import type { App } from 'vue';
 import FloatingVue from '@novu/floating-vue';
+// eslint-disable-next-line no-restricted-imports
 import '@novu/floating-vue/dist/style.css';
 import { NotificationCenterContentWebComponent } from '@novu/notification-center';