Feat: add transfer flow #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sokolova-an
commented
Dec 21, 2023
sokolova-an
commented
- Add confirmation and result pages
- Add address validation
- Add fee calculation
- Add amount validation (disabled for now for the test purpose)
- Add callbacks for MainButton and BackButton
ERussel
approved these changes
Dec 21, 2023
| const decoded = base58Decode(address); | ||
| if (!ADDRESS_ALLOWED_ENCODED_LENGTHS.includes(decoded.length)) return false; | ||
|
|
||
| const [isValid, endPos, ss58Length] = checkAddressChecksum(decoded); |
There was a problem hiding this comment.
Could you, please, clarify what result is?
There was a problem hiding this comment.
That's a function from Spectr, in the end, this function will return whether the Address is valid or not
| // should we round it more? | ||
| const max = Math.max(formattedBalance - fee, 0); | ||
| setMaxAmountToSend(max); | ||
| setSelectedAsset((prev) => ({ ...prev!, fee })); |
There was a problem hiding this comment.
Why do we need to save fee to the context?
There was a problem hiding this comment.
we use it on the next screen (confirmation)
ERussel
reviewed
Dec 21, 2023
| // commented validation for the test purpose | ||
| // TODO: uncomment it | ||
|
|
||
| // if (!isAmountValid || !Number(amount)) return; |
There was a problem hiding this comment.
Probably forgot to uncomment
There was a problem hiding this comment.
I think to leave it this way for now since we don't have a receive flow yet
what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.