Fix issues caused by thousands separator #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yes the rig items json hack I haven't been brave enough to touch, I assume D: |
|
Not sure how the test suite didn't manage to catch that one. Does rather demonstrate pretty much all it's useful for is random disruptive CI failures...... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set thousands separation manually in the invoice template rather than enabling it for localisation as a whole.
For some reason this caused issues when rig models were serialised elsewhere, we probably shouldn't be moving data around internally in localised formats but this is a quicker fix than changing those DTO methods.