Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI build version to 3.10 #598

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Oct 16, 2024

Should fix the CI test image failures.

Closes #597.

@jb3
Copy link
Member Author

jb3 commented Oct 16, 2024

We're making progress, but now the test suite seems to just be hanging after pytest runs.

@jb3
Copy link
Member Author

jb3 commented Oct 16, 2024

Passed!

image

I don't see any functionality to trigger a deploy here, does Heroku pick changes up automatically?

The suite just runs tests and calls it quits there.

@jb3
Copy link
Member Author

jb3 commented Oct 16, 2024

There is a manual deploy job as well which could do something.

If Heroku deployments are failing someone please drop me a copy of the logs (here or joe@jb3.dev if sensitive content) and I'll try see what's happening there.

Copy link

@nickw29 nickw29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe, Heroku should deploy it automatically I think

@nickw29 nickw29 merged commit ec000be into nottinghamtec:master Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI builder python version issue
2 participants