-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactor, added 2 custom libraries, fixed overlay movement #58
base: master
Are you sure you want to change the base?
Conversation
No need to crowd the base directory, Code at this point doesn't support it, don't use this commit
1. Using BetterStashTabAPI 2. Using BetterFilterAPI 3. Fixed the Overaly movement 4. Added a Sync thread 5. Major code refactor and commenting the whole code 6. Extracted most "magic values" out of the code 7. Added a better filter selection dialog 8. Removed redundant code 9. Changed the highlight code to not use exec() 10. Highlights will now use the actual item size and not a preset number 11. Better debug printing by wrapping the original pprint function 12. Better screen resolution config handling 13. Remade the overlay content to better show how many identified and unidentified items there are 14. Changed the paths to work with the new folder structure
Now you can use pip install -r requirements to setup all the libraries needed
A bug I found - Accidentaly I am using os.exit instead of using sys.exit. this results in an error instead of a clean exit, but it doesn't break the functionality of the code, fixing it now |
This should allow the ability to put full paths in the setup.ini file in case of custom filter directories
…_all_by_tag a little
So i'm trying to test this branch out, but i'm having a ton of trouble closing the program since the extra thread is not being handled on close. I am trying to figure out how to handle it, but you might be able to quicker. |
Thats odd, the thread is set to daemon mode, one sec, ill reimplement the function so that it doesn't sleep for 10 seconds |
Try it now, it now sleeps only half a seconds and each time it checks if enough time elapsed from the previous stash_sync check Nevermind, I see what you mean, the gui closes but the python keeps on running, ill see what I can do |
Added a way to close it, not the best code but the whole GUI side of the app still needs a refactor so that the tkApp only handles the GUI and separate out the logic into a different class and functions that are not inside the GUI class. |
self.chaos_filter_parsed=load_rules_from_base_filter( | ||
chaos_filter_path) | ||
except Exception as e: | ||
debug_print("Exception reading chaos filter: {}".format(str(e))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be self.debug_print(
This is probably too many changes for a single pull request, got carried away, whoops
Here is the gist: