Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poe_qol overwrites externally updated filter #62

Open
Irfy opened this issue Sep 29, 2020 · 1 comment
Open

poe_qol overwrites externally updated filter #62

Irfy opened this issue Sep 29, 2020 · 1 comment

Comments

@Irfy
Copy link

Irfy commented Sep 29, 2020

Instead of updating just the section designated for the chaos recipe at the top of the filter, poe_qol seems to cache the whole filter on startup and overwrites it fully every time it refreshes. This makes external update of base filter impossible while poe_qol is running.

Workaround: shut down poe_qol before updating filter, update filter, restart poe_qol.

Ideal solution: do not cache the external file, read-update-write every time. Alternatively, cache the file, but also remember its modification time, compare the modification time to last write, if not equal, read-update-write. If equal, overwrite, and update remembered modification time.

@0xdavidel
Copy link
Collaborator

This is exactly how the newest version was implemented, if this is a major concern for you I would suggest executing the python script directly instead of the executables as they are not up to date anymore.

A better solution for executing and making sure the code is up to date will be developed soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants