Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use husky instead of husky install #100

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Use husky instead of husky install #100

merged 1 commit into from
Feb 14, 2024

Conversation

akiomik
Copy link
Member

@akiomik akiomik commented Feb 1, 2024

husky v9.0.1から prepare の方法が husky install から husky に変わったため変更します。

ref: https://github.com/typicode/husky/releases/tag/v9.0.1

@akiomik akiomik requested a review from syusui-s February 1, 2024 12:25
@akiomik akiomik self-assigned this Feb 1, 2024
Copy link
Contributor

@syusui-s syusui-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

手元で動作確認して問題なく動作することを確認しました。

npm install
echo "abc" >> README.md
git add -u
git cm -m "test"

npm installを実行しないと古いバージョンのhuskyで動作しますが、問題なく動きそうです。
prepareが呼ばれるのは基本的には最初にリポジトリをクローンしてきた後のセットアップのときだけであり、既にcloneしている人にこの変更が影響はなさそうです。

@akiomik akiomik requested a review from erechorse February 1, 2024 12:46
@akiomik
Copy link
Member Author

akiomik commented Feb 1, 2024

@erechorse 権限不足かなにかでしゅうすいさんの方でapproveできなかったのでapproveいただけると🙏

@s3-odara
Copy link
Contributor

✅ erechorseです

@erechorse erechorse merged commit c223fbc into main Feb 14, 2024
1 check passed
@erechorse erechorse deleted the akiomik-patch-1 branch February 14, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants