ci: change base image to fix commitlint error #426
Conversation
.circleci/config.yml
Outdated
| jobs: | ||
| commitlint: | ||
| docker: | ||
| - image: williamlauze/circleci-commitlint:latest | ||
| - image: secretbase/circleci-commitlint:1.0.1 |
There was a problem hiding this comment.
I used the fixed version here to prevent breaking changes, If I mess up anything when updating the code.
| working_directory: ~/app | ||
|
|
||
| environment: | ||
| CIRCLE_COMPARE_URL: << pipeline.project.git_url >>/compare/<< pipeline.git.base_revision >>..<<pipeline.git.revision>> |
There was a problem hiding this comment.
Digging the source code at the upstream
https://github.com/wilau2/circleci-commitlint-step/blob/master/commitlint_range.sh#L28
CIRCLE_COMPARE_URL is not available in circle ci version 2.1 anymore
https://circleci.com/docs/2.0/env-vars/
https://discuss.circleci.com/t/is-circle-compare-url-still-a-thing/33366
So I just added an env var as example show at circle ci docs.
Hope this fix those noise when running commitlint ci job
guastallaigor
added
bug
SecretBase
force-pushed
the
ci/commitlint-fix
branch
from
e844a6e to
0cae71b
Compare
SecretBase
force-pushed
the
ci/commitlint-fix
branch
from
0cae71b to
e24662c
Compare
|
@virtuoushub OMG it work. 😭 Thank you everyone effort. Hope this can getting merge soon |
|
@SecretBase great job! Thanks for taking the initiative on publishing the new docker image. Hope you do not mind, I incorporated this PR into #418 ( https://github.com/nostalgic-css/NES.css/pull/418/files#diff-1d37e48f9ceff6d8030570cd36286a61R17-R20 ) to get the commitlint step to pass there. |
No problem. I close mine |
guastallaigor
removed
the
waiting - reviewer
Reopen the PR. Sorry for the noise.
#424
@virtuoushub
@guastallaigor
instead of waiting for the upstream image updated. I decide to spend some time to run my own image. So others everyone can moving forward.
I fork the upstream base image and make some changes same as @virtuoushub opened PR for the upstream.
https://github.com/SecretBase/circleci-commitlint-step
https://hub.docker.com/r/secretbase/circleci-commitlint/tags