From 1ebd9e8494725420b476f2141afeb11abe0202a4 Mon Sep 17 00:00:00 2001 From: Sam Duffield Date: Wed, 5 Jun 2024 15:33:54 +0100 Subject: [PATCH] Ensure inplace defaults to False --- posteriors/laplace/dense_fisher.py | 2 +- posteriors/torchopt.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/posteriors/laplace/dense_fisher.py b/posteriors/laplace/dense_fisher.py index b15f39b2..9e00702c 100644 --- a/posteriors/laplace/dense_fisher.py +++ b/posteriors/laplace/dense_fisher.py @@ -100,7 +100,7 @@ def update( batch: Any, log_posterior: LogProbFn, per_sample: bool = False, - inplace: bool = True, + inplace: bool = False, ) -> DenseLaplaceState: """Adds empirical Fisher information matrix of covariance summed over given batch. diff --git a/posteriors/torchopt.py b/posteriors/torchopt.py index d47cb38d..83f73e69 100644 --- a/posteriors/torchopt.py +++ b/posteriors/torchopt.py @@ -82,7 +82,7 @@ def update( batch: TensorTree, loss_fn: LogProbFn, optimizer: torchopt.base.GradientTransformation, - inplace: bool = True, + inplace: bool = False, ) -> TorchOptState: """Update the [TorchOpt](https://github.com/metaopt/torchopt) optimizer state.