always save chats to disk, but save them as text by default #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o changes the UI behavior to always open a 'New Chat' and setting it as current instead of setting a restored chat as current. This improves usability by not requiring the user to wait if they want to immediately start chatting.
cebtenzzre
changed the title
cebtenzzre
reviewed
Oct 11, 2023
| @@ -54,6 +54,8 @@ class Chat : public QObject | |||
| } | |||
| ChatModel *chatModel() { return m_chatModel; } | |||
|
|
|||
| bool isNewChat() const { return m_name == tr("New Chat") && !m_chatModel->count(); } | |||
There was a problem hiding this comment.
Why do we need to check the name of the chat here?
There was a problem hiding this comment.
doubly weird to match on a localized string - does it not work without that?
There was a problem hiding this comment.
We probably don't? But if someone took the time to save the chat to a new name I guess we'd want to serialize it as it is work done by the user and guessing they'd want to save to disk?
apage43
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the UI behavior to always open a 'New Chat' and setting it as current instead of setting a restored chat as current. This improves usability by not requiring the user to wait if they want to immediately start chatting.