Change the timeout for circle ci and add a fixme. (#2722)

Signed-off-by: Adam Treat <treat.adam@gmail.com>
nomic-ai · Jul 23, 2024 · 765e055 · 765e055
1 parent df510ef
commit 765e055
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.circleci/continue_config.yml b/.circleci/continue_config.yml
@@ -67,6 +67,7 @@ jobs:
             security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "$MAC_KEYCHAIN_KEY" sign.keychain
       - run:
           name: Build
+          no_output_timeout: 30m
           command: |
             mkdir build
             cd build
@@ -198,6 +199,7 @@ jobs:
             security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "$MAC_KEYCHAIN_KEY" sign.keychain
       - run:
           name: Build
+          no_output_timeout: 30m
           command: |
             mkdir build
             cd build
@@ -331,6 +333,7 @@ jobs:
             cd linuxdeployqt && qmake && sudo make install
       - run:
           name: Build
+          no_output_timeout: 30m
           command: |
             set -eo pipefail
             export CMAKE_PREFIX_PATH=~/Qt/6.5.1/gcc_64/lib/cmake
@@ -387,6 +390,7 @@ jobs:
             cd linuxdeployqt && qmake && sudo make install
       - run:
           name: Build
+          no_output_timeout: 30m
           command: |
             set -eo pipefail
             export CMAKE_PREFIX_PATH=~/Qt/6.5.1/gcc_64/lib/cmake
@@ -454,6 +458,7 @@ jobs:
             dotnet tool install --global AzureSignTool
       - run:
           name: Build
+          no_output_timeout: 30m
           command: |
             $Env:PATH = "${Env:PATH};C:\Program Files (x86)\Windows Kits\10\bin\x64"
             $Env:PATH = "${Env:PATH};C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64"
@@ -584,6 +589,7 @@ jobs:
             dotnet tool install --global AzureSignTool
       - run:
           name: Build
+          no_output_timeout: 30m
           command: |
             $Env:PATH = "${Env:PATH};C:\Program Files (x86)\Windows Kits\10\bin\x64"
             $Env:PATH = "${Env:PATH};C:\Program Files (x86)\Windows Kits\10\bin\10.0.22000.0\x64"

diff --git a/gpt4all-chat/chatllm.cpp b/gpt4all-chat/chatllm.cpp
@@ -958,6 +958,8 @@ bool ChatLLM::handleQuestionResponse(int32_t token, const std::string &response)
     m_questionResponse.append(response);
 
     // match whole question sentences
+    // FIXME: This only works with response by the model in english which is not ideal for a multi-language
+    // model.
     static const QRegularExpression reQuestion(R"(\b(What|Where|How|Why|When|Who|Which|Whose|Whom)\b[^?]*\?)");
 
     // extract all questions from response