Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable static_assert checks in to_le_radix on to_be_radix also #7224

Open
michaeljklein opened this issue Jan 29, 2025 · 0 comments
Open

Enable static_assert checks in to_le_radix on to_be_radix also #7224

michaeljklein opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@michaeljklein
Copy link
Contributor

michaeljklein commented Jan 29, 2025

Problem

  1. to_le_radix has static_assert's to ensure that the radix is a power of 2 in the range 2..=256, but to_be_radix lacks the equivalent checks
    a. (This includes tests for those checks)
  2. to_le_radix's static_assert's are only enabled in constrained execution: see here

Happy Case

  1. Use static_assert in to_be_radix to ensure that the radix is a power of 2 in the range 2..=256
  2. Enable to_le_radix's static_assert's in unconstrained execution
  3. Test these additional cases

Workaround

Yes

Workaround Description

Add the additional static_assert statements wherever to_le_radix/to_be_radix are used.

Additional Context

No response

Project Impact

Nice-to-have

Blocker Context

No response

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@michaeljklein michaeljklein added the enhancement New feature or request label Jan 29, 2025
@michaeljklein michaeljklein self-assigned this Jan 29, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant