Working Basic Checkpointing #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.14 #385 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 150 150
Lines 5646 5646
=======================================
Hits 5539 5539
Misses 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nodestream/pipeline/pipeline.py
Outdated
| @@ -129,12 +130,15 @@ class Pipeline(ExpandsSchemaFromChildren): | |||
| and running the steps in the pipeline. | |||
| """ | |||
|
|
|||
| __slots__ = ("steps", "step_outbox_size") | |||
| __slots__ = ("steps", "step_outbox_size", "logger", "logger") | |||
There was a problem hiding this comment.
Misnamed the object_store slot here
There was a problem hiding this comment.
typos - thats why :smile
Fixed!
angelosantos4
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is stacked on top of saga/checkpoints/object-store-apis
This logic wires object storage through the pipeline and into a testing extractor workload. This proves out the workflow and is working. Follow up PRs can include supporting this for more extractors.