docs: add docs for Proto package manager #6978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the Proto package manager in the site/types/release.ts, site/util/downloadUtils.ts, components/Downloads/Release/PlatformDropdown.tsx, and components/Icons/Platform/Proto.tsx files. The Proto package manager is now included as an option in the PackageManager enum and the platformItems array. The PlatformDropdown component has been updated to display the Proto icon. Additionally, the en.json file has been updated to include instructions for installing Proto.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ImBIOS
changed the title
|
#7037 will supersede this |
avivkeller
requested changes
Nov 17, 2024
There was a problem hiding this comment.
Along with that @ovflowd said, I feel that this PR changes several different parts of the code. IMHO, each part should be split into a different PR, or at least a different commit (w/ drebase), to make understanding the file history easier.
|
Also, there hasn't been any activity from the author in a little bit. If there's no activity in the next week (~4 months since open), I'm going to assume this stale-d and close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support for the Proto package manager in the site/types/release.ts, site/util/downloadUtils.ts, components/Downloads/Release/PlatformDropdown.tsx, and components/Icons/Platform/Proto.tsx files. The Proto package manager is now included as an option in the PackageManager enum and the platformItems array. The PlatformDropdown component has been updated to display the Proto icon. Additionally, the en.json file has been updated to include instructions for installing Proto.
Validation
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.