src: lock the isolate properly in IsolateData destructor

[joyeecheung]

Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65180/

[targos]

Looks like we can't do that on the main branch. Feel free to push the commit to #56959

[joyeecheung]

It seems it also fails in the V8 13.3 branch in the cctest, I suspect that this is also exposing that we aren't using HandleScope properly throughout the codebase.

[joyeecheung]

Looks like it's the cctests not locking threads and the exposure kinda spreads once someone is locking the threads. The second commits fix them locally for me.

[targos]

@nodejs/cpp-reviewers

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (85f5a6c) to head (7bfd05c).
Report is 19 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #57031   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files         665      665           
  Lines      193193   193194    +1     
  Branches    37212    37212           
=======================================
+ Hits       172158   172168   +10     
+ Misses      13775    13774    -1     
+ Partials     7260     7252    -8     

Files with missing lines	Coverage Δ
src/env.cc	85.89% <100.00%> (-0.16%)	⬇️

... and 29 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65201/ 💛