-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update V8 to 13.3.415.20 #56959
base: main
Are you sure you want to change the base?
Conversation
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 13.3. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
dllexport introduces issues when compiling with MSVC. PR-URL: nodejs#47251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
It introduces process hangs on some platforms because Node.js doesn't tear down V8 correctly. Disable it while we work on a solution. Refs: nodejs#47297 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902 PR-URL: nodejs#47450 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: nodejs#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#53134 Refs: nodejs#52809 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#55014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
It's causing compiler errors with some classes on Xcode 11 and the attribute should have no runtime effect. PR-URL: nodejs#54077 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: nodejs#55014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
It's causing linker errors with node.lib in node-gyp and potentially breaks other 3rd party tools PR-URL: nodejs#56238 Refs: nodejs#55784 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> PR-URL: nodejs#55014 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
V8 removed support for it. Refs: v8/v8@9565a9a
Refs: v8/v8@1c9f59c Refs: v8/v8@b1c5eba Refs: v8/v8@b3054f7 Refs: v8/v8@f81e87e Refs: v8/v8@dc0e305 Refs: v8/v8@41d42ce
The API was removed from V8.
This reverts commit 6857dbc.
Review requested:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
New V8 version includes more information about regular expressions.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@nodejs/platform-windows There are new compiler errors (including with clang-cl this time): |
This comment was marked as resolved.
This comment was marked as resolved.
There are some crashes in debug mode: https://ci.nodejs.org/job/node-test-commit-arm-debug/17147/ /cc @joyeecheung, seems related to cppgc |
The crash looks similar to #56327 - we probably have been forgetting to put the locker somewhere and it's somehow exposed by recent V8 changes. Looking.. |
Ping @nodejs/platform-windows |
I cannot reproduce |
Otherwise it may fail the DCHECK that uses the locked thread as a fast path to get the current thread.
Pushed the commit from #57031 |
I don't have a Windows machine at hand at the hour, but I think this should fix it for the windows-clang build from a look at the error diff --git a/deps/v8/src/wasm/wasm-module-sourcemap.cc b/deps/v8/src/wasm/wasm-module-sourcemap.cc
index f95107faba..c65389839e 100644
--- a/deps/v8/src/wasm/wasm-module-sourcemap.cc
+++ b/deps/v8/src/wasm/wasm-module-sourcemap.cc
@@ -69,7 +69,7 @@ WasmModuleSourceMap::WasmModuleSourceMap(v8::Isolate* v8_isolate,
size_t file_name_sz = file_name->Utf8LengthV2(v8_isolate) + 1;
std::unique_ptr<char[]> file_name_buf(new char[file_name_sz]);
file_name->WriteUtf8V2(v8_isolate, file_name_buf.get(), file_name_sz,
- String::WriteFlags::kNullTerminate);
+ v8::String::WriteFlags::kNullTerminate);
filenames.emplace_back(file_name_buf.get());
}
@@ -84,7 +84,7 @@ WasmModuleSourceMap::WasmModuleSourceMap(v8::Isolate* v8_isolate,
size_t mappings_sz = mappings->Utf8LengthV2(v8_isolate) + 1;
std::unique_ptr<char[]> mappings_buf(new char[mappings_sz]);
mappings->WriteUtf8V2(v8_isolate, mappings_buf.get(), mappings_sz,
- String::WriteFlags::kNullTerminate);
+ v8::String::WriteFlags::kNullTerminate);
valid_ = DecodeMapping(mappings_buf.get());
} The MSVC one looks different though. |
Notable changes:
Atomics.pause
@nodejs/v8-update @nodejs/tsc
Supersedes #56842