Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: restore changes from #55373 #56908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

sqlite: restore changes from #55373 #56908

wants to merge 1 commit into from
+10 −6

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 4, 2025

PR #55373 introduced a performance improvement for the all() method of prepared statements. Those changes appear to have been accidentally overwritten in #54181. This change restores the overwritten code.

Refs: #55373
Refs: #54181

@cjihrig
sqlite: restore changes from nodejs#55373
71ad544 
PR nodejs#55373 introduced a performance improvement for the all()
method of prepared statements. Those changes appear to have been
accidentally overwritten in nodejs#54181. This change restores the
overwritten code.

Refs: nodejs#55373
Refs: nodejs#54181
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Feb 4, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.19%. Comparing base (2388d61) to head (71ad544).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56908      +/-   ##
==========================================
- Coverage   89.19%   89.19%   -0.01%     
==========================================
  Files         665      665              
  Lines      192488   192503      +15     
  Branches    37047    37043       -4     
==========================================
+ Hits       171698   171699       +1     
- Misses      13622    13623       +1     
- Partials     7168     7181      +13
Files with missing lines Coverage Δ
src/node_sqlite.cc 79.72% <88.88%> (+0.07%) ⬆️

... and 27 files with indirect coverage changes

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64983/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64988/

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjihrig @nodejs-github-bot @targos