src: add memory retainer traits for external types #56881
Merged
+123
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `MemoryRetainerTraits` to reveal external type memory info without forcing them to inherit from `MemoryRetainer`.
nodejs-github-bot
added
c++
anonrig
approved these changes
Feb 2, 2025
jasnell
approved these changes
Feb 2, 2025
|
Oh, this should have a test added. |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Feb 2, 2025
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
addaleax
approved these changes
Feb 4, 2025
jasnell
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 316ac8c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MemoryRetainerTraitsto reveal external type memory info withoutforcing them to inherit from
MemoryRetainer.Refs: #56871 (comment)