src,test: expand test coverage for urlpattern and fix error #56878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
added
the
author ready
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56878 +/- ##
==========================================
+ Coverage 89.16% 89.18% +0.02%
==========================================
Files 665 665
Lines 192602 192601 -1
Branches 37050 37055 +5
==========================================
+ Hits 171732 171777 +45
+ Misses 13678 13642 -36
+ Partials 7192 7182 -10
|
legendecas
approved these changes
Feb 2, 2025
legendecas
added
whatwg-urlpattern
and removed
whatwg-url
anonrig
approved these changes
Feb 2, 2025
lpinca
approved these changes
Feb 2, 2025
juanarbol
approved these changes
Feb 2, 2025
juanarbol
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in eb11adf |
targos
pushed a commit
that referenced
this pull request
Feb 5, 2025
PR-URL: #56878 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve test coverage for URLPattern, fixup a typecheck error, and eliminate an unnecessary
UNREACHABLEbranch.