src: fix process exit listeners not receiving unsettled tla codes

[dario-piotrowicz]

fix listeners registered via process.on('exit', ... not receiving error code 13 when an unsettled top-level-await is encountered in the code

Fixes: #53551

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.20%. Comparing base (2bd5694) to head (549873d).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56872      +/-   ##
==========================================
+ Coverage   89.16%   89.20%   +0.03%     
==========================================
  Files         665      665              
  Lines      192602   192541      -61     
  Branches    37050    37043       -7     
==========================================
+ Hits       171732   171751      +19     
+ Misses      13678    13640      -38     
+ Partials     7192     7150      -42     

Files with missing lines	Coverage Δ
src/api/embed_helpers.cc	74.61% <100.00%> (-0.02%)	⬇️
src/api/hooks.cc	84.44% <100.00%> (+0.72%)	⬆️

... and 61 files with indirect coverage changes

[joyeecheung]

Thanks for the PR. Some comments about the approaches taken.

[joyeecheung]

Can you put these into separate tests? Otherwise we lose coverage of the cases where there isn't any exit handler installed.

[dario-piotrowicz]

Done 🙂

[joyeecheung]

I think prior to emitting the event, it should also set the kHasExitCode and kExitCode fields in the exit info buffer (basically needing an implementation of Environment::set_exit_code() that is the counter part of Environment::exit_code) so that in the handler, process.exitCode would be 13, to be consistent with other paths. Also in any case, the documentation of the exit event in doc/api/process.md should also be updated to note this extra source of exit code.

[dario-piotrowicz]

Hey @joyeecheung 👋

I've been trying to implement what you suggested and I created this set_exit_code method:

does it look ok? 🙏

The issue is that it's not fully working 😖

The problem is that as I get undefined in my test:

But I am sure that env->set_exit_code() is working since if I use it when process already has an exitCode then I can actually see the exit code changing, the issue is that when there is no exit code already set this doesn't seem to set it 😕 (this makes me suspect that I'm doing something wrong with kHasExitCode... but I don't think I am?)

do you have any idea what might be going wrong? 🙏