src: multiple urlpattern cleanups/improvements #56871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/minor-urlpattern-cleanups
branch
from
66d08c4 to
a9749a5
Compare
anonrig
added
the
commit-queue-squash
This comment was marked as outdated.
This comment was marked as outdated.
|
Hmm looks like there's a big gap in test coverage on this despite the wpt tests. Will have to look at that next |
fhinkel
approved these changes
Feb 2, 2025
jasnell
added
the
author ready
legendecas
reviewed
Feb 2, 2025
legendecas
previously requested changes
Feb 2, 2025
jasnell
force-pushed
the
jasnell/minor-urlpattern-cleanups
branch
from
a9749a5 to
120bc28
Compare
jasnell
force-pushed
the
jasnell/minor-urlpattern-cleanups
branch
from
120bc28 to
c9962a6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
Feb 2, 2025
legendecas
approved these changes
Feb 2, 2025
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added a commit
that referenced
this pull request
Feb 3, 2025
* remove USE from node_url_pattern to handle error correctly * simplify if block in node_url_pattern * improve error handling in node_url_pattern * fix error propagation on URLPattern init * use ToV8Value where more convenient in node_url_pattern * simplify URLPatternInit::ToJsObject by reducing boilerplate PR-URL: #56871 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
|
Landed in 35d199f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing up some error handling issues with
URLPatternalong with some other cleanups.