Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: filter node:quic from builtinModules when flag not used #56870

Merged
merged 1 commit into from
Feb 3, 2025
Merged

lib: filter node:quic from builtinModules when flag not used #56870

merged 1 commit into from
Feb 3, 2025

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 1, 2025

Make sure node:quic is not included in module.builtinModules when the --experimental-quic flat is not used.

@jasnell jasnell requested review from mcollina and RafaelGSS February 1, 2025 19:01
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Feb 1, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (ad84558) to head (8407395).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56870      +/-   ##
==========================================
- Coverage   89.16%   89.16%   -0.01%     
==========================================
  Files         665      665              
  Lines      192602   192606       +4     
  Branches    37052    37055       +3     
==========================================
- Hits       171743   171740       -3     
- Misses      13668    13679      +11     
+ Partials     7191     7187       -4
Files with missing lines Coverage Δ
lib/internal/modules/cjs/loader.js 98.26% <100.00%> (-0.20%) ⬇️

... and 24 files with indirect coverage changes

ljharb
ljharb approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but is this really the only module gated behind a flag? I thought sqlite was still flagged too. If not, and if this is how it was gated before, then ofc this is perfect :-)

(a test would be nice tho)

mcollina
mcollina approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/64919/ 💚

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2025
@nodejs-github-bot nodejs-github-bot merged commit 2972fe9 into nodejs:main Feb 3, 2025
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2972fe9

targos pushed a commit that referenced this pull request Feb 5, 2025
@jasnell @targos
lib: filter node:quic from builtinModules when flag not used
3b305f2 
PR-URL: #56870
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@mcollina mcollina mcollina approved these changes

@juanarbol juanarbol juanarbol approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @ljharb @mcollina @juanarbol @RafaelGSS