Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove test-asan/ubsan workflows #56823

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: remove test-asan/ubsan workflows #56823

wants to merge 1 commit into from
+0 −133

Conversation

targos
Copy link
Member

@targos targos commented Jan 30, 2025

They have been disabled for months without anyone looking into fixing the builds.

The workflows can be reintroduced later. In the mean time, this will clean up the GitHub PR checks UI.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 30, 2025
@juanarbol
Copy link
Member

CC @RafaelGSS I heard you a couple times fighting with V8 and UBSAN

RafaelGSS
RafaelGSS approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I still believe those checks are extremely valuable for the project, I have no bandwidth to support/fix it.

@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 30, 2025
@targos
tools: remove test-asan/ubsan workflows
e4c4ac3 
They have been disabled for months without anyone looking into fixing
the builds.
@targos
Copy link
Member Author

targos commented Jan 31, 2025

Rebased to fix a conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @juanarbol @jasnell @anonrig @richardlau @RafaelGSS