Temporarily increase network_family_autoselection_attempt_timeout to 500ms

[hvanness]

The timeout currently closes the connection instead of supporting parallel connections. This should be reset to 250ms if parallel connections are implemented as per RFC 8305.

This PR was initiated in this discussion, where @ShogunPanda suggested 300ms - 500ms timeout.

[nodejs-github-bot]

Review requested:

• @nodejs/net

[hvanness]

Please add notable-change label.
These docs will need to be updated

[mcollina]

Can you articulate why we should be doubling this? The other discussion is very long.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (50d405a) to head (92e1aaa).
Report is 29 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56738      +/-   ##
==========================================
- Coverage   89.22%   89.21%   -0.02%     
==========================================
  Files         663      663              
  Lines      191974   192012      +38     
  Branches    36926    36933       +7     
==========================================
+ Hits       171286   171294       +8     
- Misses      13561    13575      +14     
- Partials     7127     7143      +16     

Files with missing lines	Coverage Δ
src/node_options.h	98.33% <100.00%> (+<0.01%)	⬆️

... and 33 files with indirect coverage changes

[ShogunPanda]

@hvanness Can you please update failing tests? Once you do that, this PR will LGTM.

[hvanness]

Can you articulate why we should be doubling this? The other discussion is very long.

This is a socket connection hard timeout, which should eventually be removed from the implementation.

For now, increasing it to 500ms resolves the majority of breaking cases:
250ms is about how long it takes to connect from Australia to US East.

PS. I maintain that parallel connections are equally safe as serial. If it is possible to stop a connection to make it serial, then it must be possible to stop all connections when one parallel connection is established.

[ShogunPanda]

PS. I maintain that parallel connections are equally safe as serial. If it is possible to stop a connection to make it serial, then it must be possible to stop all connections when one parallel connection is established.

Unfortunately that's not the case. Sockets are created at C++ layer and linked to JS objects. The code is structured to have one C++ socket per JS socket and having multiple would impact significant refactoring in the code, especially w.r.t. callbacks established in many other places of the code (like TLS).