Added <cstdint> for uint64_t support #56732
Conversation
nodejs-github-bot
added
c++
|
Would you mind updating the commit message according to the contributing guide? thanks! |
|
I think this should target the main branch instead of the |
There was a problem hiding this comment.
@tjuhaszrh thanks for your first contribution. This PR should probably be targeted at the main branch -- our general policy is to land things on main first (unless the change doesn't apply there and is specific to release lines) and then our release team will handle landing the change into release lines (or indicate if a manual backport is required).
Also https://github.com/nodejs/node/actions/runs/12934388101/job/36076121164 failed -- as indicated in the output, this checks against https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines.
| @@ -9,6 +9,7 @@ | |||
| #include <string> | |||
| #include <unordered_map> | |||
| #include <unordered_set> | |||
| #include <cstdint> | |||
There was a problem hiding this comment.
Unless there's a reason not to, this should be above the #include <memory> line to keep the includes in alphabetical order.
|
@tjuhaszrh do you mind explaining reasons for the commit in the commit message? E.g. it would not be mistake to include the specific failure this is going to fix. |
|
Superseded by #56740 |
src: Adding
#include <cstdint>to worker_inspector. h for gcc v15Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes
Fixes: #56731