Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.x backport] lib: ensure FORCE_COLOR forces color output in non-TTY environments #56631

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[v22.x backport] lib: ensure FORCE_COLOR forces color output in non-TTY environments #56631

merged 1 commit into from
Feb 3, 2025

Conversation

pmarchini
Copy link
Member

This PR should backport #55404, as a manual backport is required, and also addresses #52249 in this version

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jan 16, 2025
@pmarchini pmarchini force-pushed the backport/v22.x-force-color branch from 7ec5bd7 to 61c0540 Compare January 16, 2025 20:11
@pmarchini pmarchini changed the title Backport/v22.x force color lib: ensure FORCE_COLOR forces color output in non-TTY environments Jan 16, 2025
@pmarchini pmarchini marked this pull request as ready for review January 16, 2025 20:12
cjihrig
cjihrig approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI passes.

@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64543/

@richardlau richardlau changed the title lib: ensure FORCE_COLOR forces color output in non-TTY environments [v22.x] lib: ensure FORCE_COLOR forces color output in non-TTY environments Jan 17, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64945/

@aduh95 aduh95 changed the title [v22.x] lib: ensure FORCE_COLOR forces color output in non-TTY environments [v22.x backport] lib: ensure FORCE_COLOR forces color output in non-TTY environments Feb 3, 2025
@pmarchini @aduh95
lib: ensure FORCE_COLOR forces color output in non-TTY environments
f0c556f 
PR-URL: nodejs#55404
Backport-PR-URL: nodejs#56631
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 force-pushed the backport/v22.x-force-color branch from 61c0540 to f0c556f Compare February 3, 2025 12:12
@aduh95
Copy link
Contributor

aduh95 commented Feb 3, 2025 •
edited
Loading

Landed in 793981a

@aduh95 aduh95 merged commit f0c556f into nodejs:v22.x-staging Feb 3, 2025
19 of 21 checks passed
aduh95 pushed a commit that referenced this pull request Feb 4, 2025
@pmarchini @aduh95
lib: ensure FORCE_COLOR forces color output in non-TTY environments
793981a 
PR-URL: #55404
Backport-PR-URL: #56631
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@ruyadorno ruyadorno Awaiting requested review from ruyadorno

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmarchini @nodejs-github-bot @aduh95 @lpinca @cjihrig @BridgeAR