Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update undici to 7.3.0 #56624

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jan 16, 2025

This is an automated update of undici to 7.3.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jan 16, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (2bd5694) to head (46eaec7).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56624   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files         665      665           
  Lines      192602   192602           
  Branches    37050    37060   +10     
=======================================
+ Hits       171732   171743   +11     
+ Misses      13678    13674    -4     
+ Partials     7192     7185    -7     

see 25 files with indirect coverage changes

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2025
@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 7.2.3 deps: update undici to 7.3.0 Jan 26, 2025
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-undici branch from 7f298c6 to 6ead0ab Compare January 26, 2025 00:32
@targos targos force-pushed the actions/tools-update-undici branch from 6ead0ab to f22b440 Compare January 29, 2025 09:32
@targos
Copy link
Member

targos commented Jan 29, 2025

Rebased to fix the test failure.

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2025
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-undici branch from f22b440 to 46eaec7 Compare February 2, 2025 00:33
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Feb 3, 2025
@aduh95 aduh95 added the dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. label Feb 3, 2025
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 3, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/56624
✔  Done loading data for nodejs/node/pull/56624
----------------------------------- PR info ------------------------------------
Title      deps: update undici to 7.3.0 (#56624)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-undici -> nodejs:main
Labels     lib / src, author ready, needs-ci, dependencies, dont-land-on-v18.x, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x
Commits    1
 - deps: update undici to 7.3.0
Committers 1
 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/56624
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56624
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 16 Jan 2025 09:29:39 GMT
   ✔  Approvals: 6
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2555930470
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2560935233
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2562848827
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/56624#pullrequestreview-2574204741
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2581374721
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2589524963
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-01-29T15:16:59Z: https://ci.nodejs.org/job/node-test-pull-request/64822/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - deps: update undici to 7.3.0
- Querying data for job/node-test-pull-request/64822/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/13111657431

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit 9dee7b9 into main Feb 5, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 9dee7b9

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-undici branch February 5, 2025 09:08
acidiney pushed a commit to acidiney/node that referenced this pull request Feb 23, 2025
PR-URL: nodejs#56624
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x PRs that should not land on the v23.x-staging branch and should not be released in v23.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants