-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update undici to 7.3.0 #56624
deps: update undici to 7.3.0 #56624
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56624 +/- ##
=======================================
Coverage 89.16% 89.16%
=======================================
Files 665 665
Lines 192602 192602
Branches 37050 37060 +10
=======================================
+ Hits 171732 171743 +11
+ Misses 13678 13674 -4
+ Partials 7192 7185 -7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7f298c6
to
6ead0ab
Compare
6ead0ab
to
f22b440
Compare
Rebased to fix the test failure. |
f22b440
to
46eaec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Commit Queue failed- Loading data for nodejs/node/pull/56624 ✔ Done loading data for nodejs/node/pull/56624 ----------------------------------- PR info ------------------------------------ Title deps: update undici to 7.3.0 (#56624) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-undici -> nodejs:main Labels lib / src, author ready, needs-ci, dependencies, dont-land-on-v18.x, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x Commits 1 - deps: update undici to 7.3.0 Committers 1 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/56624 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56624 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 16 Jan 2025 09:29:39 GMT ✔ Approvals: 6 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2555930470 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2560935233 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2562848827 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/56624#pullrequestreview-2574204741 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2581374721 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/56624#pullrequestreview-2589524963 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-29T15:16:59Z: https://ci.nodejs.org/job/node-test-pull-request/64822/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - deps: update undici to 7.3.0 - Querying data for job/node-test-pull-request/64822/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13111657431 |
Landed in 9dee7b9 |
PR-URL: nodejs#56624 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This is an automated update of undici to 7.3.0.