-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: allow exclude
option in globs to accept glob patterns
#56489
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
daeyeon:main.fs-glob-250105.Sun.1af9
Jan 8, 2025
Merged
fs: allow exclude
option in globs to accept glob patterns
#56489
nodejs-github-bot
merged 2 commits into
nodejs:main
from
daeyeon:main.fs-glob-250105.Sun.1af9
Jan 8, 2025
+227
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
nodejs-github-bot
added
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
labels
Jan 6, 2025
daeyeon
added
the
semver-minor
PRs that contain new features and should be released in the next minor version.
label
Jan 6, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56489 +/- ##
==========================================
+ Coverage 88.52% 89.12% +0.59%
==========================================
Files 658 662 +4
Lines 190811 191660 +849
Branches 36621 36890 +269
==========================================
+ Hits 168920 170813 +1893
+ Misses 15080 13702 -1378
- Partials 6811 7145 +334
|
jasnell
approved these changes
Jan 6, 2025
atlowChemi
approved these changes
Jan 6, 2025
daeyeon
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jan 7, 2025
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 7, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
MoLow
approved these changes
Jan 7, 2025
jazelly
approved these changes
Jan 7, 2025
CI failures are relevant to the change and aren't flakes. |
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
test at test/parallel/test-fs-glob.mjs:455:5
✖ a/**/[cg]/../[cg] - exclude: ["a/abcdef/g","a/abcfed/g","a/b/c","a/c","a/c/d/c",null] (0.156424ms)
TypeError [ERR_INVALID_ARG_TYPE]: The "options.exclude[5]" property must be of type string. Received null @jasnell Thanks for letting me know. On Windows, the exclude pattern contained a null. Fixed. |
daeyeon
added
the
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
label
Jan 8, 2025
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 8, 2025
This comment was marked as outdated.
This comment was marked as outdated.
daeyeon
added
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
and removed
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits.
labels
Jan 8, 2025
jazelly
approved these changes
Jan 8, 2025
This comment was marked as outdated.
This comment was marked as outdated.
daeyeon
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 8, 2025
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 8, 2025
Landed in dc5d0f9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
semver-minor
PRs that contain new features and should be released in the next minor version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the
exclude
option in glob functions (fs.glob
,fs.globSync
, andfsPromises.glob
) to support glob patterns.Resolves #56254
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com