Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: use buffer.toString base64 #56315

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

module: use buffer.toString base64 #56315

wants to merge 2 commits into from

Conversation

legendecas
Copy link
Member

btoa only supports latin-1 charset and produces invalid source mapping urls.

This also forbids usage of btoa in lib/ without particular reasons.

Refs: #56296

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Dec 19, 2024
@legendecas legendecas mentioned this pull request Dec 19, 2024
Open
@legendecas legendecas changed the title modules: use buffer.toString base64 module: use buffer.toString base64 Dec 19, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (0d00511) to head (5f90d08).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56315      +/-   ##
==========================================
+ Coverage   88.04%   88.54%   +0.50%     
==========================================
  Files         657      657              
  Lines      190290   190297       +7     
  Branches    36245    36535     +290     
==========================================
+ Hits       167536   168499     +963     
+ Misses      15893    14979     -914     
+ Partials     6861     6819      -42
Files with missing lines Coverage Δ
lib/internal/modules/typescript.js 100.00% <100.00%> (ø)

... and 93 files with indirect coverage changes

@legendecas
module: use buffer.toString base64
7572a08 
`btoa` only supports latin-1 charset and produces invalid source
mapping urls.
aduh95
aduh95 approved these changes Dec 19, 2024
View reviewed changes
lib/eslint.config_partial.mjs Outdated Show resolved Hide resolved
@legendecas @aduh95
fixup! module: use buffer.toString base64
5f90d08 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 19, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64120/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@legendecas @nodejs-github-bot @lpinca @anonrig @cjihrig @aduh95 @marco-ippolito