deps: update simdjson to 3.11.6 #56250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
dependencies
|
Review requested:
|
github-actions
bot
removed
the
request-ci
|
cc @nodejs/build blocked due to macOS infrastructure |
jasnell
approved these changes
Dec 28, 2024
lemire
approved these changes
Jan 6, 2025
|
@anonrig Strange. This should build with LLVM 12: https://godbolt.org/z/aK7W667WT Let me see if I can't add some checks. |
|
It turns out that Apple LLVM lies about supporting concepts. Prior to Apple LLVM 14, it is only partially supported... and so, some functionality is missing, hence the breaks. Thankfully, it should be easy enough to fix it. |
|
Version 3.11.4 should solve the issue. https://github.com/simdjson/simdjson/releases/tag/v3.11.4 |
nodejs-github-bot
changed the title
nodejs-github-bot
changed the title
marco-ippolito
approved these changes
Jan 19, 2025
RafaelGSS
approved these changes
Jan 19, 2025
|
Please see PR #56663 I believe that something is wrong with the automated updates. |
nodejs-github-bot
force-pushed
the
actions/tools-update-simdjson
branch
from
8c0e4cb to
5641f59
Compare
aduh95
force-pushed
the
actions/tools-update-simdjson
branch
from
5641f59 to
9aa8893
Compare
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
targos
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56250 ✔ Done loading data for nodejs/node/pull/56250 ----------------------------------- PR info ------------------------------------ Title deps: update simdjson to 3.11.6 (#56250) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-simdjson -> nodejs:main Labels author ready, needs-ci, dependencies Commits 1 - deps: update simdjson to 3.11.6 Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/56250 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56250 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - deps: update simdjson to 3.11.6 ℹ This PR was created on Fri, 13 Dec 2024 16:17:14 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56250#pullrequestreview-2524641283 ✔ - Daniel Lemire (@lemire): https://github.com/nodejs/node/pull/56250#pullrequestreview-2532439833 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56250#pullrequestreview-2560935187 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/56250#pullrequestreview-2561030392 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-29T08:55:44Z: https://ci.nodejs.org/job/node-test-pull-request/64812/ - Querying data for job/node-test-pull-request/64812/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13073840244 |
targos
removed
the
commit-queue-failed
targos
approved these changes
Jan 31, 2025
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 261624b |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
PR-URL: #56250 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of simdjson to 3.11.6.